Skip to content

fix: prevent setResult to emit updateBadge but state updates #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OGPoyraz merged 2 commits into from
Apr 21, 2023
Merged

fix: prevent setResult to emit updateBadge but state updates #1245

OGPoyraz merged 2 commits into from
Apr 21, 2023

Conversation

@OGPoyraz
Copy link
Member

@OGPoyraz OGPoyraz commented Apr 21, 2023 •
edited
Loading

Description

This fix makes the setResult function update state but prevents emitting the updateBadge event.

Changes

  • FIXED: Prevent AbstractMM to emit updateBadge but update state

References

This fix needed here: https://github.com/MetaMask/metamask-extension/pull/18379/files#diff-4f0b3f2fec7245e550099cba363f8bed00871b2027fb2d63efd47b2f4aa7c401R247
And patched package in the PR proves that it will fix the issue.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation for new or updated code as appropriate (note: this will usually be JSDoc)
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@OGPoyraz OGPoyraz force-pushed the fix/abstract-mm-update-emit branch from 142e867 to afb7966 Compare April 21, 2023 09:54
@OGPoyraz OGPoyraz changed the title fix: prevent setresult to emit update but state fix: prevent setResult to emit updateBadge but state updates Apr 21, 2023
@OGPoyraz OGPoyraz force-pushed the fix/abstract-mm-update-emit branch from afb7966 to 6db4b63 Compare April 21, 2023 10:00
@OGPoyraz OGPoyraz marked this pull request as ready for review April 21, 2023 10:24
@OGPoyraz OGPoyraz requested a review from a team as a code owner April 21, 2023 10:24
@OGPoyraz OGPoyraz merged commit ced8c3c into main Apr 21, 2023
@OGPoyraz OGPoyraz deleted the fix/abstract-mm-update-emit branch April 21, 2023 15:02
@legobeat legobeat mentioned this pull request Apr 25, 2023
Merged
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@OGPoyraz @MajorLift
fix: prevent setResult to emit updateBadge but state updates (#1245)
6e871b8 
fix: prevent setresult to emit update but state
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@OGPoyraz @MajorLift
fix: prevent setResult to emit updateBadge but state updates (#1245)
c051ccf 
fix: prevent setresult to emit update but state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergarces bergarces bergarces approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@OGPoyraz @bergarces