Skip to content

Remove unnecessary mock from provider API test helper #1304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Gudahtt merged 1 commit into from
May 2, 2023
Merged

Remove unnecessary mock from provider API test helper #1304

Gudahtt merged 1 commit into from
May 2, 2023

Conversation

@Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented May 2, 2023

Description

An unnecessary mock has been removed from a helper function used by network client tests. The getEIP1559Compatibility function is only called as part of lookupNetwork (which is also mocked) as of #1236, so this has been redundant since then.

Relates to #1116

Changes

None

References

Relates to #1116

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation for new or updated code as appropriate (note: this will usually be JSDoc)
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@Gudahtt
Remove unnecessary mock from provider API test helper
3d42883 
An unnecessary mock has been removed from a helper function used by
network client tests. The `getEIP1559Compatibility` function is only
called as part of `lookupNetwork` (which is also mocked) as of #1236,
so this has been redundant since then.

Relates to #1116
@Gudahtt Gudahtt requested a review from a team as a code owner May 2, 2023 18:17
mcmire
mcmire approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably just a copy-paste sort of thing from the extension side, where this works a bit differently.

@Gudahtt
Copy link
Member Author

Gudahtt commented May 2, 2023

Oh it was critical prior to #1236, but I missed this change in that PR

@Gudahtt Gudahtt merged commit c19108a into main May 2, 2023
@Gudahtt Gudahtt deleted the remove-unnecessary-mock branch May 2, 2023 18:29
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@Gudahtt @MajorLift
Remove unnecessary mock from provider API test helper (#1304)
fa28f52 
An unnecessary mock has been removed from a helper function used by
network client tests. The `getEIP1559Compatibility` function is only
called as part of `lookupNetwork` (which is also mocked) as of #1236,
so this has been redundant since then.

Relates to #1116
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@Gudahtt @MajorLift
Remove unnecessary mock from provider API test helper (#1304)
142c952 
An unnecessary mock has been removed from a helper function used by
network client tests. The `getEIP1559Compatibility` function is only
called as part of `lookupNetwork` (which is also mocked) as of #1236,
so this has been redundant since then.

Relates to #1116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcmire mcmire mcmire approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Gudahtt @mcmire