Skip to content

Remove networkid from network controller #1564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BelfordZ wants to merge 2 commits into from
Closed

Remove networkid from network controller #1564

BelfordZ wants to merge 2 commits into from

Conversation

@BelfordZ
Copy link
Contributor

@BelfordZ BelfordZ commented Jul 28, 2023

Explanation

References

Changelog

@metamask/package-a

  • : Your change here
  • : Your change here

@metamask/package-b

  • : Your change here
  • : Your change here

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@BelfordZ BelfordZ requested a review from a team as a code owner July 28, 2023 21:38
@BelfordZ BelfordZ marked this pull request as draft July 28, 2023 21:38
adonesky1
adonesky1 reviewed Jul 31, 2023
View reviewed changes
packages/ens-controller/src/EnsController.ts
onNetworkStateChange((networkState) => {
this.resetState();
// should be checking chainid, not networkId
const currentNetwork = networkState.networkId;
Copy link
Contributor

@adonesky1 adonesky1 Jul 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to remove

adonesky1
adonesky1 reviewed Jul 31, 2023
View reviewed changes
packages/ens-controller/src/EnsController.ts
// should be checking chainid, not networkId
const currentNetwork = networkState.networkId;
if (
isKnownNetworkId(currentNetwork) &&
Copy link
Contributor

@adonesky1 adonesky1 Jul 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to remove?

@BelfordZ
Copy link
Contributor Author

BelfordZ commented Oct 12, 2023

replaced by #1633

@BelfordZ BelfordZ closed this Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adonesky1 adonesky1 adonesky1 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BelfordZ @adonesky1