feat: accounts controller #1637
Conversation
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
|
@metamaskbot publish-preview |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
| "typescript": "~4.6.3" | ||
| }, | ||
| "peerDependencies": { | ||
| "@metamask/keyring-controller": "^7.4.0" |
There was a problem hiding this comment.
We can probably remove this and leave it in devDependencies
There was a problem hiding this comment.
yes, we can remove the peerDependencies. Changed in 2c2fa52
There was a problem hiding this comment.
I might have given a wrong suggestion here:
Seeing how we use messenger events/actions types in other packages, we usually include the package they come from in dependencies and peerDependencies, probably to ensure that we use the same versions of that package across the dep tree
@Gudahtt might have more insights on this, but I think we should rollback these changes - sorry about that.
There was a problem hiding this comment.
no problem, the change has been rolled back in d5e3b8e
Co-authored-by: Michele Esposito <34438276+mikesposito@users.noreply.github.com>
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
mikesposito
left a comment
mikesposito
left a comment
There was a problem hiding this comment.
Just one more question
Other than that, looks good!
|
@montelaidev What do you think about moving repos for this package for the time being? 🤔 |
## Explanation Adds a new controller, `accounts-controller` that introduces the `InternalAccount` model. The InternalAccount will be used to represent accounts instead of an ethereum address. ### `@metamask/accounts-controller` - **ADDED**: Initial release ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate --------- Co-authored-by: Daniel Rocha <68558152+danroc@users.noreply.github.com> Co-authored-by: Michele Esposito <34438276+mikesposito@users.noreply.github.com>
## Explanation Adds a new controller, `accounts-controller` that introduces the `InternalAccount` model. The InternalAccount will be used to represent accounts instead of an ethereum address. ### `@metamask/accounts-controller` - **ADDED**: Initial release ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate --------- Co-authored-by: Daniel Rocha <68558152+danroc@users.noreply.github.com> Co-authored-by: Michele Esposito <34438276+mikesposito@users.noreply.github.com>
Explanation
Adds a new controller,
accounts-controllerthat introduces theInternalAccountmodel. The InternalAccount will be used to represent accounts instead of an ethereum address.@metamask/accounts-controllerChecklist