Add check the network status whenever signing a transaction #1711
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR aims to modify
getCommonConfigurationto check ifnetworkStatus.Available.Context
The extension
TransactionControllerchecks the network status whenever signing a transaction and if it is notNetworkStatus.Availablethe chain ID of the request is set to0. This causes the@ethereumjs/txpackage to throw an error when building the transaction as it will not match the generated network configuration.The behaviour is the same as before just an additional check to help reduce the difference between the core and the extension
TransactionController.References
Changelog
@metamask/transaction-controllergetCommonConfigurationto check ifnetworkStatus.Availablewhenever signing a transaction.Checklist