Skip to content

Conversation

@vinistevam
Copy link
Contributor

Explanation

This PR aims to modify getCommonConfiguration to check if networkStatus.Available.

Context
The extension TransactionController checks the network status whenever signing a transaction and if it is not NetworkStatus.Available the chain ID of the request is set to 0. This causes the @ethereumjs/tx package to throw an error when building the transaction as it will not match the generated network configuration.

The behaviour is the same as before just an additional check to help reduce the difference between the core and the extension TransactionController.

References

Changelog

@metamask/transaction-controller

  • CHANGED: update getCommonConfiguration to check if networkStatus.Available whenever signing a transaction.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@vinistevam vinistevam marked this pull request as ready for review September 25, 2023 12:59
@vinistevam vinistevam requested a review from a team as a code owner September 25, 2023 12:59
@vinistevam
Copy link
Contributor Author

Closing this ticket due to networkId deprecation. PR

@vinistevam vinistevam closed this Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants