chore: Remove AbortController polyfill #1726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
remove-abort-controller-polyfill
branch
2 times, most recently
from
1df733d to
2d7efd1
Compare
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: abort-controller@3.0.0 |
Gudahtt
force-pushed
the
remove-abort-controller-polyfill
branch
from
2d7efd1 to
1e12807
Compare
Mrtenz
approved these changes
Sep 26, 2023
The `AbortController` polyfill has not been required since updating to a minimum Node.js version of v16 in #1262. This API has been built into Node.js since v15.4.0, and is included in all versions of v16. It is also supported by all browsers that our extension supports, and has been supported by React Native since v0.60.0. This helps unblock the TypeScript update to v4.8.4. The update resulted in some type errors from this polyfill package.
Gudahtt
force-pushed
the
remove-abort-controller-polyfill
branch
from
1e12807 to
b3361ac
Compare
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
## Explanation The `AbortController` polyfill has not been required since updating to a minimum Node.js version of v16 in #1262. This API has been [built into Node.js since v15.4.0](https://nodejs.org/docs/latest-v16.x/api/globals.html#class-abortcontroller), and is included in all versions of v16. It is also supported by [all browsers that our extension supports](https://developer.mozilla.org/en-US/docs/Web/API/AbortController#browser_compatibility), and has been [supported by React Native since v0.60.0](https://github.com/react-native-community/releases/blob/master/CHANGELOG.md#v0600). This helps unblock the TypeScript update to v4.8.4. The update resulted in some type errors from this polyfill package. ## References None ## Changelog ### `@metamask/assets-controllers` ### Removed - **BREAKING:** Remove AbortController polyfill - This package now assumes that the AbortController global exists ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
## Explanation The `AbortController` polyfill has not been required since updating to a minimum Node.js version of v16 in #1262. This API has been [built into Node.js since v15.4.0](https://nodejs.org/docs/latest-v16.x/api/globals.html#class-abortcontroller), and is included in all versions of v16. It is also supported by [all browsers that our extension supports](https://developer.mozilla.org/en-US/docs/Web/API/AbortController#browser_compatibility), and has been [supported by React Native since v0.60.0](https://github.com/react-native-community/releases/blob/master/CHANGELOG.md#v0600). This helps unblock the TypeScript update to v4.8.4. The update resulted in some type errors from this polyfill package. ## References None ## Changelog ### `@metamask/assets-controllers` ### Removed - **BREAKING:** Remove AbortController polyfill - This package now assumes that the AbortController global exists ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The
AbortControllerpolyfill has not been required since updating to a minimum Node.js version of v16 in #1262. This API has been built into Node.js since v15.4.0, and is included in all versions of v16. It is also supported by all browsers that our extension supports, and has been supported by React Native since v0.60.0.This helps unblock the TypeScript update to v4.8.4. The update resulted in some type errors from this polyfill package.
References
None
Changelog
@metamask/assets-controllersRemoved
Checklist