deps(approval-controller): move to @metamask/rpc-errors #1743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legobeat
force-pushed
the
deps-rpc-errors-approval-controller
branch
from
0507a4f to
a21caa0
Compare
3 tasks
legobeat
requested review from
a team,
Gudahtt,
danroc,
jiexi,
mikesposito and
montelaidev
legobeat
force-pushed
the
deps-rpc-errors-approval-controller
branch
from
a21caa0 to
f9b3726
Compare
Mrtenz
approved these changes
Sep 30, 2023
3 tasks
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
## Explanation This replaces obsolete `eth-rpc-errors` with `@metamask/rpc-errors` in `@metamask/approval-controller`. This should be coupled with #1639 and can be merged before or after. ## References #### Broken out from - #1731 #### Blocking - #1724 #### Related - #1690 ## Changelog ### `@metamask/approval-controller` - **Changed**: Replaced `eth-rpc-errors` with `@metamask/rpc-errors` ### `@metamask/controller-utils` - **Fixed**: Removed unused dependency `eth-rpc-errors` ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
## Explanation This replaces obsolete `eth-rpc-errors` with `@metamask/rpc-errors` in `@metamask/approval-controller`. This should be coupled with #1639 and can be merged before or after. ## References #### Broken out from - #1731 #### Blocking - #1724 #### Related - #1690 ## Changelog ### `@metamask/approval-controller` - **Changed**: Replaced `eth-rpc-errors` with `@metamask/rpc-errors` ### `@metamask/controller-utils` - **Fixed**: Removed unused dependency `eth-rpc-errors` ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate
MajorLift
pushed a commit
that referenced
this pull request
Oct 12, 2023
## Explanation This replaces obsolete `eth-rpc-errors` with `@metamask/rpc-errors` in `@metamask/approval-controller`. This should be coupled with #1639 and can be merged before or after. ## References #### Broken out from - #1731 #### Blocking - #1724 #### Related - #1690 ## Changelog ### `@metamask/approval-controller` - **Changed**: Replaced `eth-rpc-errors` with `@metamask/rpc-errors` ### `@metamask/controller-utils` - **Fixed**: Removed unused dependency `eth-rpc-errors` ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This replaces obsolete
eth-rpc-errorswith@metamask/rpc-errorsin@metamask/approval-controller. This should be coupled with #1639 and can be merged before or after.References
Broken out from
@metamask/rpc-errorsinapproval-controller#1731Blocking
@metamask/json-rpc-engineand@metamask/utils#1724Related
Changelog
@metamask/approval-controllereth-rpc-errorswith@metamask/rpc-errors@metamask/controller-utilseth-rpc-errorsChecklist