Skip to content

Revert "Migrate eth-json-rpc-provider into core monorepo (1/2)" #1753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MajorLift merged 1 commit into from
Oct 2, 2023
Merged

Revert "Migrate eth-json-rpc-provider into core monorepo (1/2)" #1753

MajorLift merged 1 commit into from
Oct 2, 2023

Conversation

@MajorLift
Copy link
Contributor

@MajorLift MajorLift commented Oct 2, 2023 •
edited
Loading

Reverts #1737

@MajorLift MajorLift requested a review from a team as a code owner October 2, 2023 15:16
@socket-security
Copy link

socket-security bot commented Oct 2, 2023

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: @metamask/auto-changelog@3.1.0, @types/jest@28.1.8, @types/node@17.0.23, depcheck@1.4.3, eslint-config-prettier@8.5.0, eslint-plugin-jest@27.1.5, jest@28.1.3, prettier@2.7.1, prettier-plugin-packagejson@2.4.5, ts-jest@28.0.8, typedoc@0.23.28

Gudahtt
Gudahtt approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MajorLift MajorLift merged commit eca9e10 into main Oct 2, 2023
@MajorLift MajorLift deleted the revert-1737-230927-migrate-eth-json-rpc-provider branch October 2, 2023 15:21
@MajorLift MajorLift self-assigned this Oct 5, 2023
@MajorLift MajorLift added team-wallet-framework Deprecated: Please use `team-core-platform` instead. enhancement New feature or request labels Oct 5, 2023
MajorLift added a commit that referenced this pull request Oct 11, 2023
@MajorLift
Revert "Migrate eth-json-rpc-provider into core monorepo (1/2)" (#1753
0747521 
)

Reverts #1737

- The intention for this PR was to preserve the full git history of the
original repo, which means the commits shouldn't have been squashed
while merging.
- #1737 will be re-merged using the `--no-ff` option, which will be
temporarily enabled by admin.
MajorLift added a commit that referenced this pull request Oct 11, 2023
@MajorLift
Revert "Migrate eth-json-rpc-provider into core monorepo (1/2)" (#1753
a9fa7a4 
)

Reverts #1737

- The intention for this PR was to preserve the full git history of the
original repo, which means the commits shouldn't have been squashed
while merging.
- #1737 will be re-merged using the `--no-ff` option, which will be
temporarily enabled by admin.
MajorLift added a commit that referenced this pull request Oct 12, 2023
@MajorLift
Revert "Migrate eth-json-rpc-provider into core monorepo (1/2)" (#1753
f3a6c45 
)

Reverts #1737

- The intention for this PR was to preserve the full git history of the
original repo, which means the commits shouldn't have been squashed
while merging.
- #1737 will be re-merged using the `--no-ff` option, which will be
temporarily enabled by admin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees

@MajorLift MajorLift

Labels

enhancement New feature or request team-wallet-framework Deprecated: Please use `team-core-platform` instead.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MajorLift @Gudahtt