Add getNonceLock method #1859
Merged
Add getNonceLock method #1859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OGPoyraz
previously approved these changes
Oct 17, 2023
| expect(transactionsListener).toHaveBeenCalledTimes(0); | ||
| }); | ||
|
|
||
| it('logs error while checking the status of a submitted transaction', async () => { |
Member
There was a problem hiding this comment.
A pattern for us to decide on, but typically I don't create unit tests for logging as it's not true business logic, but rather just to aid debugging so could bloat the test file if we did it for every instance.
That said, we could adapt this unit test to instead just ensure we don't throw in the event listener if the query fails?
Contributor
Author
There was a problem hiding this comment.
I agree, most of the time it's not worth creating unit tests for logging.
As it's already done I adapted as you suggested.
packages/transaction-controller/src/helpers/PendingTransactionTracker.ts
Show resolved
Hide resolved
Co-authored-by: Matthew Walsh <matthew.walsh@consensys.net>
vinistevam
force-pushed
the
refactor/1468-add-getNonceLock-method
branch
from
f6a599a to
97c3698
Compare
OGPoyraz
approved these changes
Oct 24, 2023
matthewwalsh0
approved these changes
Oct 24, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The extension
TransactionControllerexposes thenonceTrackerproperty from which thegetNonceLockmethod is used by UI and some other controllers. This PR aims to expose to the public API thegetNonceLock.GlobalNonceLockbefore starting checking for submitted transactions inPendingtransactionTracker.getNonceLockin theTransactionController.References
Changelog
@metamask/transaction-controllerNonceTrackertoPendingTransactionTracker.getNonceLockenabling to retrieve the next nonce according to the nonce-tracker.Checklist