Skip to content

Conversation

@MajorLift
Copy link
Contributor

Explanation

Adds an "Installation" and "Contributing" section to the @metamask/json-rpc-engine README, as it has been migrated into the monorepo.

In future migrations, this step will be performed in "Phase B" (see #1551 (comment)), while the package is being staged in the merged-packages/ temporary directory.

References

Changelog

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@MajorLift MajorLift added the team-wallet-framework Deprecated: Please use `team-core-platform` instead. label Nov 7, 2023
@MajorLift MajorLift self-assigned this Nov 7, 2023
@MajorLift MajorLift requested a review from a team as a code owner November 7, 2023 02:09
Copy link
Member

@mikesposito mikesposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MajorLift MajorLift merged commit 9342a1a into main Nov 7, 2023
@MajorLift MajorLift deleted the 231106-update-readme-json-rpc-engine branch November 7, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-wallet-framework Deprecated: Please use `team-core-platform` instead.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants