Expose keyrings #23
Merged
Expose keyrings #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 18 18
Lines 889 889
Branches 97 97
=====================================
Hits 889 889Continue to review full report at Codecov.
|
bitpshr
approved these changes
Nov 14, 2018
Contributor
bitpshr
left a comment
bitpshr
left a comment
There was a problem hiding this comment.
Looks good. One comment, then this can be merged.
rickycodes
added a commit
that referenced
this pull request
Nov 23, 2022
mcmire
added a commit
to mcmire/core
that referenced
this pull request
Jul 17, 2023
In order for another project to use the logging functions provided by this library, which make use of `debug`, `@types/debug` also needs to be available. This is not a total blocker — `@types/debug` can be added manually to the project in question — but is inconvenient. This commit moves `@types/debug` to the list of `dependencies` to address this.
MajorLift
pushed a commit
that referenced
this pull request
Sep 22, 2023
Required by update of `@metamask/json-rpc-engine` (#16)
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Expose keyrings * Bump version * add keyrings to state * update package-lock.json * bump version again * dont override state * obj ref * bump version * return checksummed addresses * undo version bump
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Expose keyrings * Bump version * add keyrings to state * update package-lock.json * bump version again * dont override state * obj ref * bump version * return checksummed addresses * undo version bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GABA
KeyringControllerstate only exposes the encrypted vault but for account rendering purposes it's good to expose all the keyrings, their types and they public keys of each one (which is what the extension is already doing). This PR attempts to expose that newkeyringsflag.