Eth and personal sign #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
brunobar79
approved these changes
Nov 27, 2018
Contributor
brunobar79
left a comment
brunobar79
left a comment
There was a problem hiding this comment.
Minor comments but this is solid stuff @estebanmino 💯
| import { EventEmitter } from 'events'; | ||
| import BaseController, { BaseConfig, BaseState } from './BaseController'; | ||
| import { validatePersonalSignMessageData, normalizeMessageData } from './util'; | ||
| const random = require('uuid/v1'); |
Contributor
Author
There was a problem hiding this comment.
honestly I didn't question this, TransactionController uses the same and imports it in the same way
Contributor
There was a problem hiding this comment.
You're right. Other files are also using require. Maybe we should standardize? cc: @bitpshr
src/PersonalMessageManager.ts
Outdated
| /** | ||
| * @type Message | ||
| * | ||
| * Represents, and contains data about, an 'personal_sign' type signature request. |
Contributor
There was a problem hiding this comment.
"Represents, and contains data about a 'personal_sign' type signature request."
src/PersonalMessageManager.ts
Outdated
| * @property id - An id to track and identify the message object | ||
| * @property messageParams - The parameters to pass to the personal_sign method once the signature request is approved | ||
| * @property type - The json-prc signing method for which a signature request has been made. | ||
| * A 'Message' with always have a 'personal_sign' type |
Contributor
There was a problem hiding this comment.
"A 'Message' which always has..."
src/PersonalMessageManager.ts
Outdated
| /** | ||
| * @type MessageParamsMetamask | ||
| * | ||
| * Represents, the parameters to pass to the personal_sign method once the signature request is approved |
Contributor
There was a problem hiding this comment.
Represents the (remove comma)
| * | ||
| */ | ||
| getUnapprovedMessages() { | ||
| return this.messages |
Contributor
There was a problem hiding this comment.
ES6 + Functional programming + TypeScript = 💣 🔥
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
======================================
Coverage 100% 100%
======================================
Files 18 19 +1
Lines 889 989 +100
Branches 97 107 +10
======================================
+ Hits 889 989 +100
Continue to review full report at Codecov.
|
mcmire
pushed a commit
to mcmire/core
that referenced
this pull request
Jul 17, 2023
MajorLift
added a commit
that referenced
this pull request
Sep 29, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* add message manager * start message manager test * handle metamaskId * complete message manager tests * delete unnecessary imports * delete generated file * emit unapprovedMessage & keyring signMessage * update to PersonalMessageManager * update to PersonalMessageManager * add signPersonalMessage * eth_sign to personal_sign * fix signPersonalMessage * update doc * emit updateBadge when save messages * update doc * Update personalSIgn util tests description
MajorLift
added a commit
that referenced
this pull request
Oct 11, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* add message manager * start message manager test * handle metamaskId * complete message manager tests * delete unnecessary imports * delete generated file * emit unapprovedMessage & keyring signMessage * update to PersonalMessageManager * update to PersonalMessageManager * add signPersonalMessage * eth_sign to personal_sign * fix signPersonalMessage * update doc * emit updateBadge when save messages * update doc * Update personalSIgn util tests description
MajorLift
added a commit
that referenced
this pull request
Oct 11, 2023
Mrtenz
pushed a commit
that referenced
this pull request
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mostly a migration to ts of this to have both eth_sign and personal_sign as proposed here MetaMask/metamask-extension#4117
It also exposes
signPersonalMessagefrometh-keyring-controller