Remove default approval controller type #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
Mrtenz
pushed a commit
that referenced
this pull request
Oct 16, 2025
This PR does the following: - bumps `action-create-release-pr` to `v3` (May fix https://github.com/MetaMask/create-release-branch/actions/runs/14524263811) - formats `CHANGELOG.md` using Prettier and updates the pipelines to use the correct parameters for changelog validation: both non-RC `yarn auto-changelog validate --prettier` and RC `yarn auto-changelog validate --rc --prettier` branches.
Mrtenz
pushed a commit
that referenced
this pull request
Oct 16, 2025
There seems to be a regression in Node 22.5.0 which [prevents `yarn install` from running][1] and in turns prevents CI from completing successfully. This regression was [fixed in 22.5.1][2]. We are using `22.x` in CI, so in theory it should be using this version, but that does not seem be the case right now. So this commit ensures that CI is using this version by naming it explicitly. [1]: yarnpkg/berry#6398 [2]: nodejs/node#53935
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the default approval controller type, and requires an explicitly specified type for all approvals.