Skip to content

Bump min Node version to 18.18; use LTS for dev #3611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcmire merged 9 commits into from
May 31, 2024
Merged

Bump min Node version to 18.18; use LTS for dev #3611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ef75d97
Bump min Node version to 18.18; use LTS for dev
mcmire Dec 1, 2023
ffa1961
Merge branch 'main' into bump-all-packages-to-node-18
mcmire Mar 22, 2024
ed4635a
Merge branch 'main' into bump-all-packages-to-node-18
legobeat Apr 18, 2024
7dc6b2d
Merge branch 'main' into bump-all-packages-to-node-18
mcmire Apr 19, 2024
3ec0128
Merge branch 'main' into bump-all-packages-to-node-18
legobeat Apr 25, 2024
86f99b9
Merge branch 'main' into bump-all-packages-to-node-18
legobeat Apr 30, 2024
ea2ef45
Merge branch 'main' into bump-all-packages-to-node-18
mcmire May 31, 2024
9c7e11a
Bump Node on two new packages
mcmire May 31, 2024
5338f7e
Merge branch 'main' into bump-all-packages-to-node-18
mcmire May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/lint-build-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [16.x, 18.x, 20.x]
node-version: [18.x, 20.x]
outputs:
child-workspace-package-names: ${{ steps.workspace-package-names.outputs.child-workspace-package-names }}
steps:
Expand Down Expand Up @@ -105,7 +105,7 @@ jobs:
needs: prepare
strategy:
matrix:
node-version: [16.x, 18.x, 20.x]
node-version: [18.x, 20.x]
package-name: ${{ fromJson(needs.prepare.outputs.child-workspace-package-names) }}
steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v16
lts/*
4 changes: 2 additions & 2 deletions constraints.pro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,8 +408,8 @@ gen_enforced_dependency(WorkspaceCwd, DependencyIdent, CorrectPeerDependencyRang
atom_concat('^', CurrentDependencyVersion, CorrectPeerDependencyRange)
).

% All packages must specify a minimum Node version of 16.
gen_enforced_field(WorkspaceCwd, 'engines.node', '>=16.0.0').
% All packages must specify a minimum Node version of 18.
gen_enforced_field(WorkspaceCwd, 'engines.node', '^18.18 || >=20').

% All published packages are public.
gen_enforced_field(WorkspaceCwd, 'publishConfig.access', 'public') :-
Expand Down
4 changes: 2 additions & 2 deletions docs/contributing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

## Getting started

- Install [Node.js](https://nodejs.org) version 16.
- If you're using [NVM](https://github.com/creationix/nvm#installation) (recommended), `nvm use` will ensure that the right version is installed.
- Install the current LTS version of [Node.js](https://nodejs.org)
- If you are using [nvm](https://github.com/creationix/nvm#installation) (recommended) running `nvm install` will install the latest version and running `nvm use` will automatically choose the right node version for you.
- Install [Yarn v3](https://yarnpkg.com/getting-started/install).
- Run `yarn install` to install dependencies and run any required post-install scripts.
- Run `yarn simple-git-hooks` to add a [Git hook](https://github.com/toplenboren/simple-git-hooks#what-is-a-git-hook) to your local development environment which will ensure that all files pass linting before you push a branch.
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
},
"packageManager": "yarn@3.3.0",
"engines": {
"node": ">=16.0.0"
"node": "^18.18 || >=20"
},
"lavamoat": {
"allowScripts": {
Expand Down
2 changes: 1 addition & 1 deletion packages/accounts-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
"@metamask/snaps-controllers": "^8.1.1"
},
"engines": {
"node": ">=16.0.0"
"node": "^18.18 || >=20"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/address-book-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"typescript": "~4.9.5"
},
"engines": {
"node": ">=16.0.0"
"node": "^18.18 || >=20"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/announcement-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"typescript": "~4.9.5"
},
"engines": {
"node": ">=16.0.0"
"node": "^18.18 || >=20"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/approval-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"typescript": "~4.9.5"
},
"engines": {
"node": ">=16.0.0"
"node": "^18.18 || >=20"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/assets-controllers/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
"@metamask/preferences-controller": "^12.0.0"
},
"engines": {
"node": ">=16.0.0"
"node": "^18.18 || >=20"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/base-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"typescript": "~4.9.5"
},
"engines": {
"node": ">=16.0.0"
"node": "^18.18 || >=20"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/build-utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"typescript": "~4.9.5"
},
"engines": {
"node": ">=16.0.0"
"node": "^18.18 || >=20"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/chain-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"typescript": "~4.9.5"
},
"engines": {
"node": ">=16.0.0"
"node": "^18.18 || >=20"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/composable-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
"typescript": "~4.9.5"
},
"engines": {
"node": ">=16.0.0"
"node": "^18.18 || >=20"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/controller-utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
"typescript": "~4.9.5"
},
"engines": {
"node": ">=16.0.0"
"node": "^18.18 || >=20"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/ens-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"@metamask/network-controller": "^18.1.3"
},
"engines": {
"node": ">=16.0.0"
"node": "^18.18 || >=20"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/eth-json-rpc-provider/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
},
"packageManager": "yarn@3.3.0",
"engines": {
"node": ">=16.0.0"
"node": "^18.18 || >=20"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/gas-fee-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
"@metamask/network-controller": "^18.1.3"
},
"engines": {
"node": ">=16.0.0"
"node": "^18.18 || >=20"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/json-rpc-engine/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
},
"packageManager": "yarn@3.3.0",
"engines": {
"node": ">=16.0.0"
"node": "^18.18 || >=20"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/json-rpc-middleware-stream/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
"webextension-polyfill-ts": "^0.26.0"
},
"engines": {
"node": ">=16.0.0"
"node": "^18.18 || >=20"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/keyring-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
"uuid": "^8.3.2"
},
"engines": {
"node": ">=16.0.0"
"node": "^18.18 || >=20"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/logging-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"typescript": "~4.9.5"
},
"engines": {
"node": ">=16.0.0"
"node": "^18.18 || >=20"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/message-manager/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"typescript": "~4.9.5"
},
"engines": {
"node": ">=16.0.0"
"node": "^18.18 || >=20"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/name-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"typescript": "~4.9.5"
},
"engines": {
"node": ">=16.0.0"
"node": "^18.18 || >=20"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/network-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
"typescript": "~4.9.5"
},
"engines": {
"node": ">=16.0.0"
"node": "^18.18 || >=20"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/notification-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"typescript": "~4.9.5"
},
"engines": {
"node": ">=16.0.0"
"node": "^18.18 || >=20"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/permission-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
"@metamask/approval-controller": "^6.0.0"
},
"engines": {
"node": ">=16.0.0"
"node": "^18.18 || >=20"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/permission-log-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
"typescript": "~4.9.5"
},
"engines": {
"node": ">=16.0.0"
"node": "^18.18 || >=20"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/phishing-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"typescript": "~4.9.5"
},
"engines": {
"node": ">=16.0.0"
"node": "^18.18 || >=20"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/polling-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
"@metamask/network-controller": "^18.1.3"
},
"engines": {
"node": ">=16.0.0"
"node": "^18.18 || >=20"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/preferences-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"@metamask/keyring-controller": "^16.0.0"
},
"engines": {
"node": ">=16.0.0"
"node": "^18.18 || >=20"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/profile-sync-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
"typescript": "~4.9.5"
},
"engines": {
"node": ">=16.0.0"
"node": "^18.18 || >=20"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/queued-request-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
"@metamask/selected-network-controller": "^14.0.0"
},
"engines": {
"node": ">=16.0.0"
"node": "^18.18 || >=20"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/rate-limit-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"typescript": "~4.9.5"
},
"engines": {
"node": ">=16.0.0"
"node": "^18.18 || >=20"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/selected-network-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
"@metamask/permission-controller": "^9.1.1"
},
"engines": {
"node": ">=16.0.0"
"node": "^18.18 || >=20"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/signature-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
"@metamask/logging-controller": "^4.0.0"
},
"engines": {
"node": ">=16.0.0"
"node": "^18.18 || >=20"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/transaction-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
"@metamask/network-controller": "^18.1.3"
},
"engines": {
"node": ">=16.0.0"
"node": "^18.18 || >=20"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/user-operation-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
"@metamask/transaction-controller": "^31.0.0"
},
"engines": {
"node": ">=16.0.0"
"node": "^18.18 || >=20"
},
"publishConfig": {
"access": "public",
Expand Down