Skip to content

Move keyring-controller dep to devdep in Accounts Controller #3820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
montelaidev merged 1 commit into from
Jan 23, 2024
Merged

Move keyring-controller dep to devdep in Accounts Controller #3820

montelaidev merged 1 commit into from
Jan 23, 2024

Conversation

@montelaidev
Copy link
Contributor

@montelaidev montelaidev commented Jan 23, 2024 •
edited by Gudahtt
Loading

Explanation

Move the keyring-controller from a dependency to to dev dependency in Accounts Controller. This was accidentally recategorized in #3747, this PR undoes that change.

References

Changelog

@metamask/accounts-controller

  • Changed: Move keyring-controller from a dependency to devDependency in the AccountsController

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@montelaidev montelaidev requested a review from a team as a code owner January 23, 2024 13:20
@Gudahtt
Copy link
Member

Gudahtt commented Jan 23, 2024

I've updated the PR description to add a little more context

Gudahtt
Gudahtt approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@montelaidev montelaidev merged commit de3dc1a into main Jan 23, 2024
@montelaidev montelaidev deleted the fix/move-keyring-dep-to-dev-dependency branch January 23, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

+1 more reviewer

@legobeat legobeat legobeat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@montelaidev @Gudahtt @legobeat