exclude fields from token list fetch #4235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hurricanenara
previously approved these changes
Apr 30, 2024
hurricanenara
previously approved these changes
Apr 30, 2024
sahar-fehri
previously approved these changes
May 1, 2024
sahar-fehri
approved these changes
May 31, 2024
mcmire
pushed a commit
that referenced
this pull request
May 31, 2024
## Explanation Adds 2 query parameters when fetching token lists: - `includeERC20Permit=false` - `includeStorage=false` The best I can tell, neither field is used by extension or mobile. So we'll instead take the reduction in network usage (~5KB on mainnet) and controller state. ## References https://consensyssoftware.atlassian.net/browse/API-1186 ## Changelog ### `@metamask/assets-controllers` - **BREAKING**: `TokenListController` no longer includes the fields `storage` and `erc20Permit` in its state. ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Adds 2 query parameters when fetching token lists:
includeERC20Permit=falseincludeStorage=falseThe best I can tell, neither field is used by extension or mobile. So we'll instead take the reduction in network usage (~5KB on mainnet) and controller state.
References
https://consensyssoftware.atlassian.net/browse/API-1186
Changelog
@metamask/assets-controllersTokenListControllerno longer includes the fieldsstorageanderc20Permitin its state.Checklist