Skip to content

feat: migrate NftDetectionController to BaseControllerV2 #4312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cryptodev-2s merged 21 commits into from
May 30, 2024
Merged

feat: migrate NftDetectionController to BaseControllerV2 #4312

cryptodev-2s merged 21 commits into from
May 30, 2024

Conversation

@cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented May 23, 2024 •
edited
Loading

Explanation

The NftDetectionController has been migrated to BaseControllerV2. As part of this migration, the deprecated config property has been removed and replaced with messenger actions for chainId and selectedAddress retrieval..

References

Changelog

@metamask/assets-controllers

Changed

  • BREAKING: Convert NftDetectionController to BaseControllerV2

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@cryptodev-2s cryptodev-2s requested a review from a team May 23, 2024 14:04
@cryptodev-2s cryptodev-2s added the team-wallet-framework Deprecated: Please use `team-core-platform` instead. label May 23, 2024
@desi desi requested a review from a team May 23, 2024 19:15
@cryptodev-2s cryptodev-2s force-pushed the feature/migrate-nft-detection-controller-to-base-controller-v2 branch from e28003f to 0d6e4fa Compare May 23, 2024 20:55
kanthesha
kanthesha suggested changes May 28, 2024
View reviewed changes
kanthesha
kanthesha suggested changes May 28, 2024
View reviewed changes
kanthesha
kanthesha suggested changes May 28, 2024
View reviewed changes
@cryptodev-2s cryptodev-2s requested a review from kanthesha May 28, 2024 13:37
kanthesha
kanthesha reviewed May 28, 2024
View reviewed changes
@cryptodev-2s cryptodev-2s requested a review from kanthesha May 28, 2024 15:02
kanthesha
kanthesha previously approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@kanthesha kanthesha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

kanthesha
kanthesha approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@kanthesha kanthesha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cryptodev-2s cryptodev-2s merged commit f522918 into main May 30, 2024
@cryptodev-2s cryptodev-2s deleted the feature/migrate-nft-detection-controller-to-base-controller-v2 branch May 30, 2024 08:42
@mcmire mcmire mentioned this pull request May 30, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kanthesha kanthesha kanthesha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

team-wallet-framework Deprecated: Please use `team-core-platform` instead.

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Convert NftDetectionController from BaseControllerV1 to BaseControllerV2

3 participants

@cryptodev-2s @kanthesha