Skip to content

Conversation

@dbrans
Copy link
Contributor

@dbrans dbrans commented Jun 6, 2024

Explanation

Met with @matthewwalsh0 who took the time to explain each status.

References

Changelog

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@dbrans dbrans added amon-hen team-transactions Transactions team and removed amon-hen labels Jun 6, 2024
@dbrans dbrans marked this pull request as ready for review June 6, 2024 18:08
@dbrans dbrans requested a review from a team June 6, 2024 18:08
@dbrans dbrans changed the title chore: document TransactionStatus enum docs: document TransactionStatus enum Jun 6, 2024
@dbrans dbrans force-pushed the dbrans/tx-status-doc branch from 0242e8c to 9e07236 Compare June 19, 2024 19:40
@dbrans dbrans requested review from Gudahtt and matthewwalsh0 June 19, 2024 19:44
Copy link
Member

@mikesposito mikesposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@dbrans dbrans merged commit d51609f into main Jun 20, 2024
@dbrans dbrans deleted the dbrans/tx-status-doc branch June 20, 2024 13:00
@matthewwalsh0
Copy link
Member

❤️

mcmire pushed a commit that referenced this pull request Jun 20, 2024
## Explanation
Met with @matthewwalsh0 who took the time to explain each status.

## References

## Changelog

## Checklist

- [ ] I've updated the test suite for new or updated code as appropriate
- [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [ ] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
@montelaidev montelaidev mentioned this pull request Jun 25, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-transactions Transactions team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants