Skip to content

fix: disable some transaction controller integration tests #4429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shanejonas merged 4 commits into from
Jun 19, 2024
Merged

fix: disable some transaction controller integration tests #4429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
07a999f
fix: disable some transaction controller integration tests
shanejonas Jun 14, 2024
d76ef47
update jest coverage
jiexi Jun 14, 2024
5b751cc
Merge branch 'main' into fix/disable-some-integration-tests
dbrans Jun 19, 2024
cea1ed6
Merge branch 'main' into fix/disable-some-integration-tests
shanejonas Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/transaction-controller/jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ module.exports = merge(baseConfig, {
global: {
branches: 93.65,
functions: 98.38,
lines: 98.84,
statements: 98.85,
lines: 98.8,
statements: 98.81,
},
},

Expand Down
15 changes: 10 additions & 5 deletions packages/transaction-controller/src/TransactionControllerIntegration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,8 @@ describe('TransactionController Integration', () => {
transactionController.destroy();
});

it('should submit all approved transactions in state', async () => {
// eslint-disable-next-line jest/no-disabled-tests
it.skip('should submit all approved transactions in state', async () => {
mockNetwork({
networkClientConfiguration: buildInfuraNetworkClientConfiguration(
InfuraNetworkType.goerli,
Expand Down Expand Up @@ -804,7 +805,8 @@ describe('TransactionController Integration', () => {
});

describe('when transactions are added concurrently with different networkClientIds but on the same chainId', () => {
it('should add each transaction with consecutive nonces', async () => {
// eslint-disable-next-line jest/no-disabled-tests
it.skip('should add each transaction with consecutive nonces', async () => {
mockNetwork({
networkClientConfiguration: buildInfuraNetworkClientConfiguration(
InfuraNetworkType.goerli,
Expand Down Expand Up @@ -913,7 +915,8 @@ describe('TransactionController Integration', () => {
});

describe('when transactions are added concurrently with the same networkClientId', () => {
it('should add each transaction with consecutive nonces', async () => {
// eslint-disable-next-line jest/no-disabled-tests
it.skip('should add each transaction with consecutive nonces', async () => {
mockNetwork({
networkClientConfiguration: buildInfuraNetworkClientConfiguration(
InfuraNetworkType.goerli,
Expand Down Expand Up @@ -1191,7 +1194,8 @@ describe('TransactionController Integration', () => {

describe('startIncomingTransactionPolling', () => {
// TODO(JL): IncomingTransactionHelper doesn't populate networkClientId on the generated tx object. Should it?..
it('should add incoming transactions to state with the correct chainId for the given networkClientId on the next block', async () => {
// eslint-disable-next-line jest/no-disabled-tests
it.skip('should add incoming transactions to state with the correct chainId for the given networkClientId on the next block', async () => {
mockNetwork({
networkClientConfiguration: buildInfuraNetworkClientConfiguration(
InfuraNetworkType.mainnet,
Expand Down Expand Up @@ -1617,7 +1621,8 @@ describe('TransactionController Integration', () => {
});

describe('updateIncomingTransactions', () => {
it('should add incoming transactions to state with the correct chainId for the given networkClientId without waiting for the next block', async () => {
// eslint-disable-next-line jest/no-disabled-tests
it.skip('should add incoming transactions to state with the correct chainId for the given networkClientId without waiting for the next block', async () => {
const selectedAddress = ETHERSCAN_TRANSACTION_BASE_MOCK.to;
const selectedAccountMock = createMockInternalAccount({
address: selectedAddress,
Expand Down