Skip to content

Conversation

@jiexi
Copy link
Contributor

@jiexi jiexi commented Jun 18, 2024

Releases queued-request-controller methods array constructor param to callback constructor param update

@jiexi
Copy link
Contributor Author

jiexi commented Jun 18, 2024

@metamaskbot publish-preview

@github-actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/accounts-controller": "17.0.0-preview-707aca2",
  "@metamask-previews/address-book-controller": "5.0.0-preview-707aca2",
  "@metamask-previews/announcement-controller": "7.0.0-preview-707aca2",
  "@metamask-previews/approval-controller": "7.0.0-preview-707aca2",
  "@metamask-previews/assets-controllers": "33.0.0-preview-707aca2",
  "@metamask-previews/base-controller": "6.0.0-preview-707aca2",
  "@metamask-previews/build-utils": "3.0.0-preview-707aca2",
  "@metamask-previews/chain-controller": "0.1.0-preview-707aca2",
  "@metamask-previews/composable-controller": "7.0.0-preview-707aca2",
  "@metamask-previews/controller-utils": "11.0.0-preview-707aca2",
  "@metamask-previews/ens-controller": "12.0.0-preview-707aca2",
  "@metamask-previews/eth-json-rpc-provider": "4.0.0-preview-707aca2",
  "@metamask-previews/gas-fee-controller": "17.0.0-preview-707aca2",
  "@metamask-previews/json-rpc-engine": "9.0.0-preview-707aca2",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.0-preview-707aca2",
  "@metamask-previews/keyring-controller": "17.1.0-preview-707aca2",
  "@metamask-previews/logging-controller": "5.0.0-preview-707aca2",
  "@metamask-previews/message-manager": "10.0.0-preview-707aca2",
  "@metamask-previews/name-controller": "8.0.0-preview-707aca2",
  "@metamask-previews/network-controller": "19.0.0-preview-707aca2",
  "@metamask-previews/notification-controller": "6.0.0-preview-707aca2",
  "@metamask-previews/notification-services-controller": "0.0.0-preview-707aca2",
  "@metamask-previews/permission-controller": "10.0.0-preview-707aca2",
  "@metamask-previews/permission-log-controller": "3.0.0-preview-707aca2",
  "@metamask-previews/phishing-controller": "10.0.0-preview-707aca2",
  "@metamask-previews/polling-controller": "8.0.0-preview-707aca2",
  "@metamask-previews/preferences-controller": "13.0.0-preview-707aca2",
  "@metamask-previews/profile-sync-controller": "0.0.0-preview-707aca2",
  "@metamask-previews/queued-request-controller": "1.0.0-preview-707aca2",
  "@metamask-previews/rate-limit-controller": "6.0.0-preview-707aca2",
  "@metamask-previews/selected-network-controller": "15.0.2-preview-707aca2",
  "@metamask-previews/signature-controller": "18.0.0-preview-707aca2",
  "@metamask-previews/transaction-controller": "33.0.0-preview-707aca2",
  "@metamask-previews/user-operation-controller": "12.0.0-preview-707aca2"
}

@jiexi jiexi marked this pull request as ready for review June 18, 2024 16:38
@jiexi jiexi requested review from a team, Gudahtt and adonesky1 June 18, 2024 16:38
{
"name": "@metamask/queued-request-controller",
"version": "0.12.0",
"version": "1.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oooo he did it. Stepping into the major leagues 🤣

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha can change this back to minor if preferred

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah its time for this boy to become a man

adonesky1
adonesky1 previously approved these changes Jun 18, 2024
Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a couple nits

Co-authored-by: Alex Donesky <adonesky@gmail.com>
Co-authored-by: Alex Donesky <adonesky@gmail.com>
@jiexi jiexi merged commit fdc880e into main Jun 18, 2024
@jiexi jiexi deleted the release/162.0.0 branch June 18, 2024 18:39
mcmire pushed a commit that referenced this pull request Jun 20, 2024
Releases `queued-request-controller` methods array constructor param to
callback constructor param update

---------

Co-authored-by: Alex Donesky <adonesky@gmail.com>
staging-devin-ai-integration bot pushed a commit to Devin-Applications/core-devin that referenced this pull request Jul 11, 2024
Releases `queued-request-controller` methods array constructor param to
callback constructor param update

---------

Co-authored-by: Alex Donesky <adonesky@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants