Skip to content

Conversation

@Prithpal-Sooriya
Copy link
Contributor

@Prithpal-Sooriya Prithpal-Sooriya commented Jun 19, 2024

Explanation

it seems we were inconsistent and forgot to correctly handle default exports and controller exports

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

it seems we were inconsistent and forgot to correctly handle default exports and controller exports
@Prithpal-Sooriya Prithpal-Sooriya added the team-notifications Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications label Jun 19, 2024
@Prithpal-Sooriya Prithpal-Sooriya requested a review from a team June 19, 2024 12:30
Copy link
Contributor

@Jonathansoufer Jonathansoufer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Prithpal-Sooriya Prithpal-Sooriya merged commit d95b351 into main Jun 19, 2024
@Prithpal-Sooriya Prithpal-Sooriya deleted the refactor-tidy-notification-exports branch June 19, 2024 12:35
mcmire pushed a commit that referenced this pull request Jun 20, 2024
## Explanation

it seems we were inconsistent and forgot to correctly handle default
exports and controller exports

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
staging-devin-ai-integration bot pushed a commit to Devin-Applications/core-devin that referenced this pull request Jul 11, 2024
## Explanation

it seems we were inconsistent and forgot to correctly handle default
exports and controller exports

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-notifications Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants