Skip to content

Conversation

@Prithpal-Sooriya
Copy link
Contributor

Explanation

This was removed as it was blocking publishing of profile sync controller. Adding here so it unblocks the next release for this controller: #4438

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

this was removed as it was blocking publishing of profile sync controller
@Prithpal-Sooriya Prithpal-Sooriya requested a review from a team June 19, 2024 14:15
@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/profile-sync-controller@0.0.0 network 0 275 kB metamaskbot

View full report↗︎

@socket-security
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Network access npm/@metamask/profile-sync-controller@0.0.0 🚫

View full report↗︎

Next steps

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/@metamask/profile-sync-controller@0.0.0

@Prithpal-Sooriya Prithpal-Sooriya added the team-notifications Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications label Jun 19, 2024
Copy link
Contributor

@Jonathansoufer Jonathansoufer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Prithpal-Sooriya Prithpal-Sooriya merged commit b558134 into main Jun 19, 2024
@Prithpal-Sooriya Prithpal-Sooriya deleted the refactor-add-back-profile-sync-deps branch June 19, 2024 14:19
mcmire pushed a commit that referenced this pull request Jun 20, 2024
## Explanation

This was removed as it was blocking publishing of profile sync
controller. Adding here so it unblocks the next release for this
controller: #4438


## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
staging-devin-ai-integration bot pushed a commit to Devin-Applications/core-devin that referenced this pull request Jul 11, 2024
## Explanation

This was removed as it was blocking publishing of profile sync
controller. Adding here so it unblocks the next release for this
controller: MetaMask#4438


## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-notifications Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants