Skip to content

Conversation

@bergeron
Copy link
Contributor

@bergeron bergeron commented Oct 17, 2024

The goal of this release is to release #4752, where the polling controller input was made more flexible. It's a major breaking change to all polling controllers.

Dependent controllers the tool thought should be released are included too.

@bergeron bergeron requested review from a team as code owners October 17, 2024 18:06
@bergeron bergeron requested a review from a team October 17, 2024 18:06
gambinish
gambinish previously approved these changes Oct 17, 2024
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
Copy link
Contributor

@MajorLift MajorLift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates to polling controller entries for consistency with #4810 (comment):

bergeron and others added 3 commits October 18, 2024 08:34
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
MajorLift
MajorLift previously approved these changes Oct 18, 2024
gambinish
gambinish previously approved these changes Oct 18, 2024
@bergeron bergeron dismissed stale reviews from gambinish and MajorLift via e22206c October 21, 2024 14:56
@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/utils@9.2.1 None +1 719 kB metamaskbot

View full report↗︎

@bergeron bergeron merged commit 5c04d50 into main Oct 21, 2024
@bergeron bergeron deleted the release/223.0.0 branch October 21, 2024 15:45

### Changed

- Bump `@metamask/eth-json-rpc-provider` from `^4.1.4` to `^4.1.5` ([#4798](https://github.com/MetaMask/core/pull/4798))
Copy link
Contributor

@legobeat legobeat Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bergeron Noting that this change was merged BREAKING (#4769) but released as non-breaking. Looks like this may have been missed for the release?

Is this fine or should @metamask/network-controller be re-released as 22.0.0?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Even if it was non-breaking, it certainly should have been listed here as a change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants