Skip to content

Conversation

@mathieuartu
Copy link
Contributor

@mathieuartu mathieuartu commented Jan 10, 2025

Explanation

This is a RC for v279.0.0. See changelog for more details

@metamask/profile-sync-controller@3.3.0

References

Changelog

### Changed

- Bump `@metamask/profile-sync-controller` from `^3.2.0` to `^3.3.0` ([#5130](https://github.com/MetaMask/core/pull/5130))

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@mathieuartu mathieuartu added the team-identity Identity Team changes. https://github.com/orgs/MetaMask/teams/identity label Jan 10, 2025
@mathieuartu mathieuartu self-assigned this Jan 10, 2025
### Changed

- Bump `eslint` to `^9.11.1` and migrate to flat config ([#4727](https://github.com/MetaMask/core/pull/4727))
- Bump `@metamask/keyring-api` from `^12.0.0` to `^13.0.0` and `@metamask/keyring-internal-api` from `^1.0.0` to `^1.1.0` ([#5066](https://github.com/MetaMask/core/pull/5066))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, will need to double check docs. Since this includes a "major" dependency bump, should our package also be a major bump?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically looking at the PR: #5066
It seems like for this package it was not a breaking change, so we could stick with a minor version bump.

However we can raise if this should be a major bump for consistency.

Copy link
Contributor

@Prithpal-Sooriya Prithpal-Sooriya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but may need to change from minor to major.

@mathieuartu mathieuartu marked this pull request as ready for review January 12, 2025 21:11
@mathieuartu mathieuartu requested review from a team as code owners January 12, 2025 21:11
@mathieuartu mathieuartu merged commit 76af6eb into main Jan 13, 2025
120 checks passed
@mathieuartu mathieuartu deleted the release/279.0.0 branch January 13, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-identity Identity Team changes. https://github.com/orgs/MetaMask/teams/identity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants