breaking: Remove deprecated messenger-related exports and aliases #5260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptodev-2s
added
the
team-wallet-framework
cryptodev-2s
changed the title
cryptodev-2s
force-pushed
the
cryptodev2s/remove-old-messenger
branch
from
6d03427 to
6ae88ac
Compare
4 tasks
cryptodev-2s
force-pushed
the
cryptodev2s/remove-old-messenger
branch
4 times, most recently
from
dc02969 to
deb8a84
Compare
cryptodev-2s
force-pushed
the
cryptodev2s/remove-old-messenger
branch
from
deb8a84 to
6ca65af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR removes several deprecated exports and aliases from the
base-controllerpackage to simplify the codebase and reduce confusion. The following changes are made:ControllerMessengerexport (was an alias forMessenger)RestrictedControllerMessengerexport (was an alias forRestrictedMessenger)RestrictedControllerMessengerConstrainttype export (was an alias forRestrictedMessengerConstraint)RestrictedMessengerconstructor by removing the deprecatedcontrollerMessengerparameter in favor of using only themessengerparameterThese aliases were originally introduced to help with migration but are no longer needed
References
Related to #4538
Changelog
See CHANGELOG changes
Checklist