Skip to content

feat: add gas fee tokens to transaction metadata#5524

Merged
matthewwalsh0 merged 8 commits intomainfrom
feat/gas-fee-tokens
Mar 25, 2025
Merged

feat: add gas fee tokens to transaction metadata#5524
matthewwalsh0 merged 8 commits intomainfrom
feat/gas-fee-tokens

Conversation

@matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Mar 21, 2025 •
edited
Loading

Explanation

Retrieve the available gas fee tokens from the simulation API when adding a transaction, and save them in the transaction metadata.

Specifically:

  • Add gasFeeTokens to TransactionMetadata.
  • Add selectedGasFeeToken to TransactionMetadata.
  • Add additional request and response properties to types in utils/simulation-api.ts.
  • Update utils/simulation.ts to parse the gas fee tokens from the response.

References

Fixes #4458

Changelog

See CHANGELOG.md.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@matthewwalsh0
Copy link
Member Author

matthewwalsh0 commented Mar 21, 2025

@metamaskbot publish-preview

@github-actions
Copy link
Contributor

github-actions bot commented Mar 21, 2025

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "27.0.0-preview-e56c504a",
  "@metamask-previews/address-book-controller": "6.0.3-preview-e56c504a",
  "@metamask-previews/announcement-controller": "7.0.3-preview-e56c504a",
  "@metamask-previews/approval-controller": "7.1.3-preview-e56c504a",
  "@metamask-previews/assets-controllers": "55.0.1-preview-e56c504a",
  "@metamask-previews/base-controller": "8.0.0-preview-e56c504a",
  "@metamask-previews/bridge-controller": "10.0.0-preview-e56c504a",
  "@metamask-previews/bridge-status-controller": "10.0.0-preview-e56c504a",
  "@metamask-previews/build-utils": "3.0.3-preview-e56c504a",
  "@metamask-previews/chain-agnostic-permission": "0.1.0-preview-e56c504a",
  "@metamask-previews/composable-controller": "11.0.0-preview-e56c504a",
  "@metamask-previews/controller-utils": "11.6.0-preview-e56c504a",
  "@metamask-previews/earn-controller": "0.9.0-preview-e56c504a",
  "@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-e56c504a",
  "@metamask-previews/ens-controller": "16.0.0-preview-e56c504a",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-e56c504a",
  "@metamask-previews/gas-fee-controller": "23.0.0-preview-e56c504a",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-e56c504a",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-e56c504a",
  "@metamask-previews/keyring-controller": "21.0.0-preview-e56c504a",
  "@metamask-previews/logging-controller": "6.0.4-preview-e56c504a",
  "@metamask-previews/message-manager": "12.0.1-preview-e56c504a",
  "@metamask-previews/multichain": "4.0.0-preview-e56c504a",
  "@metamask-previews/multichain-api-middleware": "0.1.0-preview-e56c504a",
  "@metamask-previews/multichain-network-controller": "0.3.0-preview-e56c504a",
  "@metamask-previews/multichain-transactions-controller": "0.8.0-preview-e56c504a",
  "@metamask-previews/name-controller": "8.0.3-preview-e56c504a",
  "@metamask-previews/network-controller": "23.0.0-preview-e56c504a",
  "@metamask-previews/notification-services-controller": "5.0.0-preview-e56c504a",
  "@metamask-previews/permission-controller": "11.0.6-preview-e56c504a",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-e56c504a",
  "@metamask-previews/phishing-controller": "12.4.1-preview-e56c504a",
  "@metamask-previews/polling-controller": "13.0.0-preview-e56c504a",
  "@metamask-previews/preferences-controller": "17.0.0-preview-e56c504a",
  "@metamask-previews/profile-sync-controller": "11.0.0-preview-e56c504a",
  "@metamask-previews/queued-request-controller": "10.0.0-preview-e56c504a",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-e56c504a",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-e56c504a",
  "@metamask-previews/sample-controllers": "0.0.0-preview-e56c504a",
  "@metamask-previews/selected-network-controller": "22.0.0-preview-e56c504a",
  "@metamask-previews/signature-controller": "27.0.0-preview-e56c504a",
  "@metamask-previews/token-search-discovery-controller": "2.1.0-preview-e56c504a",
  "@metamask-previews/transaction-controller": "52.0.0-preview-e56c504a",
  "@metamask-previews/user-operation-controller": "31.0.0-preview-e56c504a"
}

@matthewwalsh0 matthewwalsh0 changed the base branch from main to feat/publish-batch-hook March 24, 2025 21:13
@matthewwalsh0 matthewwalsh0 marked this pull request as ready for review March 24, 2025 21:15
@matthewwalsh0 matthewwalsh0 requested review from a team as code owners March 24, 2025 21:15
@matthewwalsh0
Copy link
Member Author

matthewwalsh0 commented Mar 24, 2025

@metamaskbot publish-preview

@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2025

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "27.0.0-preview-35da3ac",
  "@metamask-previews/address-book-controller": "6.0.3-preview-35da3ac",
  "@metamask-previews/announcement-controller": "7.0.3-preview-35da3ac",
  "@metamask-previews/approval-controller": "7.1.3-preview-35da3ac",
  "@metamask-previews/assets-controllers": "55.0.1-preview-35da3ac",
  "@metamask-previews/base-controller": "8.0.0-preview-35da3ac",
  "@metamask-previews/bridge-controller": "11.0.0-preview-35da3ac",
  "@metamask-previews/bridge-status-controller": "10.0.0-preview-35da3ac",
  "@metamask-previews/build-utils": "3.0.3-preview-35da3ac",
  "@metamask-previews/chain-agnostic-permission": "0.2.0-preview-35da3ac",
  "@metamask-previews/composable-controller": "11.0.0-preview-35da3ac",
  "@metamask-previews/controller-utils": "11.6.0-preview-35da3ac",
  "@metamask-previews/earn-controller": "0.9.0-preview-35da3ac",
  "@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-35da3ac",
  "@metamask-previews/ens-controller": "16.0.0-preview-35da3ac",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-35da3ac",
  "@metamask-previews/gas-fee-controller": "23.0.0-preview-35da3ac",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-35da3ac",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-35da3ac",
  "@metamask-previews/keyring-controller": "21.0.0-preview-35da3ac",
  "@metamask-previews/logging-controller": "6.0.4-preview-35da3ac",
  "@metamask-previews/message-manager": "12.0.1-preview-35da3ac",
  "@metamask-previews/multichain": "4.0.0-preview-35da3ac",
  "@metamask-previews/multichain-api-middleware": "0.1.1-preview-35da3ac",
  "@metamask-previews/multichain-network-controller": "0.3.0-preview-35da3ac",
  "@metamask-previews/multichain-transactions-controller": "0.8.0-preview-35da3ac",
  "@metamask-previews/name-controller": "8.0.3-preview-35da3ac",
  "@metamask-previews/network-controller": "23.1.0-preview-35da3ac",
  "@metamask-previews/notification-services-controller": "5.0.1-preview-35da3ac",
  "@metamask-previews/permission-controller": "11.0.6-preview-35da3ac",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-35da3ac",
  "@metamask-previews/phishing-controller": "12.4.1-preview-35da3ac",
  "@metamask-previews/polling-controller": "13.0.0-preview-35da3ac",
  "@metamask-previews/preferences-controller": "17.0.0-preview-35da3ac",
  "@metamask-previews/profile-sync-controller": "11.0.0-preview-35da3ac",
  "@metamask-previews/queued-request-controller": "10.0.0-preview-35da3ac",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-35da3ac",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-35da3ac",
  "@metamask-previews/sample-controllers": "0.0.0-preview-35da3ac",
  "@metamask-previews/selected-network-controller": "22.0.0-preview-35da3ac",
  "@metamask-previews/signature-controller": "27.0.0-preview-35da3ac",
  "@metamask-previews/token-search-discovery-controller": "2.1.0-preview-35da3ac",
  "@metamask-previews/transaction-controller": "52.1.0-preview-35da3ac",
  "@metamask-previews/user-operation-controller": "31.0.0-preview-35da3ac"
}

@matthewwalsh0 matthewwalsh0 force-pushed the feat/publish-batch-hook branch from 7ee3ac2 to f723ee3 Compare March 25, 2025 10:52
Base automatically changed from feat/publish-batch-hook to main March 25, 2025 10:57
pedronfigueiredo
pedronfigueiredo reviewed Mar 25, 2025
View reviewed changes
@matthewwalsh0 matthewwalsh0 enabled auto-merge (squash) March 25, 2025 16:12
@matthewwalsh0 matthewwalsh0 merged commit 3913167 into main Mar 25, 2025
193 checks passed
@matthewwalsh0 matthewwalsh0 deleted the feat/gas-fee-tokens branch March 25, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OGPoyraz OGPoyraz OGPoyraz approved these changes

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

Assignees

No one assigned

Labels

team-confirmations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@matthewwalsh0 @OGPoyraz @pedronfigueiredo