refactor: address tech debt for chain agnostic permission code repeated on extension and mobile codebases #6225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffmcgee725
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
jiexi
reviewed
Aug 4, 2025
Comment on lines
+571
to
+572
| * Requests user approval for the CAIP-25 permission | ||
| * and returns a granted permissions object. |
Member
Author
wenfix
approved these changes
Aug 5, 2025
ffmcgee725
added a commit
that referenced
this pull request
Aug 5, 2025
## @metamask/chain-agnostic-permission ## [1.1.0] ### Added - Added `getCaip25PermissionFromLegacyPermissions` and `requestPermittedChainsPermissionIncremental` misc functions. ([#6225](#6225)) ### Changed - Bump `@metamask/controller-utils` from `^11.10.0` to `^11.11.0` ([#6069](#6069)) - Bump `@metamask/network-controller` from `^24.0.0` to `^24.0.1` ([#6148](#6148)) - Bump `@metamask/utils` from `^11.2.0` to `^11.4.2` ([#6054](#6054))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
While working on adding Multichain API to Flask on mobile, some code that is common to the browser extension repository was also created on the mobile codebase, namely these permissions utilities which are also present in the
extensionmetamask-controller module:getCaip25PermissionFromLegacyPermissionsrequestPermittedChainsPermissionIncrementalThe work proposed in this pull request migrates these common functionalities onto our
@metamask/chain-agnostic-permissionspackage, so that they can be imported on bothmobileandextensionto be used.References
Changelog
Checklist