Skip to content

Release 508.0.0 #6355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Gudahtt merged 5 commits into from
Aug 21, 2025
Merged

Release 508.0.0 #6355

Gudahtt merged 5 commits into from
Aug 21, 2025

Conversation

@Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Aug 21, 2025

This is the initial release of the @metamask/messenger package and the experimental next export of @metamask/base-controller.

Gudahtt
Gudahtt commented Aug 21, 2025
View reviewed changes
packages/messenger/CHANGELOG.md

### Fixed

- Update `unsubscribe` type signature to support selector event handlers ([#6262](https://github.com/MetaMask/core/pull/6262))
Copy link
Member Author

@Gudahtt Gudahtt Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this because it was already published under base-controller, so wasn't really "new" anymore, considering the migration from base-controller as the starting point.

@Gudahtt
Copy link
Member Author

Gudahtt commented Aug 21, 2025

Adding no-changelog because the changelog check job is complaining two unreleased packages not referencing the version bump in their changelogs. But they're not released yet, so there is no need to list any "changes" from the previous non-existent release.

Also it's complaining about the base-controller changelog not including the messenger version bump from 0.0.0 to 0.1.0 for some reason. But this is not really a version bump since it was not added until this release (and the addition of the dependency is documented), so the job is wrong here as well I think.

@Gudahtt Gudahtt marked this pull request as ready for review August 21, 2025 13:24
@Gudahtt Gudahtt requested review from a team as code owners August 21, 2025 13:24
mathieuartu
mathieuartu approved these changes Aug 21, 2025
View reviewed changes
Copy link
Contributor

@mathieuartu mathieuartu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mcmire
mcmire approved these changes Aug 21, 2025
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit 1029647 into main Aug 21, 2025
251 of 252 checks passed
@Gudahtt Gudahtt deleted the release/508.0.0 branch August 21, 2025 13:31
@cryptodev-2s
Copy link
Contributor

cryptodev-2s commented Aug 21, 2025

Adding no-changelog because the changelog check job is complaining two unreleased packages not referencing the version bump in their changelogs. But they're not released yet, so there is no need to list any "changes" from the previous non-existent release.

Also it's complaining about the base-controller changelog not including the messenger version bump from 0.0.0 to 0.1.0 for some reason. But this is not really a version bump since it was not added until this release (and the addition of the dependency is documented), so the job is wrong here as well I think.

On the unreleased packages:
Our recent practice is to include an “Initial release” section in CHANGELOG.md even before the first publish, and keep appending PRs (including dependency bumps) under that section. That lets us track all changes from the initial commit up to the first release.

On the base-controller check:
Agreed—the job only detects “dependency updated” and doesn’t distinguish “newly added.” While 0.0.0 → 0.1.0 isn’t really a bump, we can either:

  • add a brief line under Added noting the new dependency at 0.1.0 (to satisfy the check), or
  • skip it and follow up by improving the check’s logic to recognize first-time additions. (I can create an issue for this)

This was referenced Sep 22, 2025
Merged
Closed
Merged
jeffsmale90 added a commit that referenced this pull request Sep 24, 2025
@jeffsmale90
Release/577.0.0 (#6702)
6d2c3b0 
## Explanation

Releases @metamask/signature-controller@34.0.0

### Added

- Add two new controller state metadata properties: `includeInStateLogs`
and `usedInUi` ([#6473](#6473))
- **BREAKING:** Decode delegation permissions using
`@metamask/gator-permissions-controller` when calling
`newUnsignedTypedMessage`, adds `@metamask/gator-permissions-controller`
as a peer dependency.
([#6619](#6619))

### Changed

- Bump `@metamask/controller-utils` from `^11.12.0` to `^11.14.0`
([#6620](#6620),
[#6629](#6629))
- Bump `@metamask/base-controller` from `^8.1.0` to `^8.4.0`
([#6355](#6355),
[#6465](#6465),
[#6632](#6632))
- Bump `@metamask/utils` from `^11.4.2` to `^11.8.0`
([#6588](#6588))
- Bump `@metamask/network-controller` from `^24.1.0` to `^24.2.0`
([#6678](#6678))
- Bump `@metamask/keyring-controller` from `^23.0.0` to `^23.1.0`
([#6590](#6590))
- Bump `@metamask/accounts-controller` from `^33.0.0` to `^33.1.0`
([#6572](#6572))
github-merge-queue bot pushed a commit to MetaMask/metamask-extension that referenced this pull request Sep 24, 2025
@mikesposito
chore: bump @metamask/message-manager to ^13.0.0 (#35701)
9134f6b 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
Bump `@metamask/message-manager` dependency:

```markdown
- **BREAKING:** `AbstractMessageManager` now expects a `Name extends string` generic parameter to define the name of the message manager ([#6469](MetaMask/core#6469))
  - The type is used as namespace for `BaseController` and `Messenger` events and actions.
- Bump `@metamask/base-controller` from `^8.0.1` to `^8.3.0` ([#6284](MetaMask/core#6284), [#6355](MetaMask/core#6355), [#6465](MetaMask/core#6465))
- Bump `@metamask/controller-utils` from `^11.11.0` to `^11.12.0` ([#6303](MetaMask/core#6303))
```

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/35701?quickstart=1)

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

## **Related issues**

Fixes: To be created once major version is published 

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@AugmentedMode AugmentedMode mentioned this pull request Sep 24, 2025
Closed
4 tasks
github-merge-queue bot pushed a commit to MetaMask/metamask-mobile that referenced this pull request Oct 21, 2025
@jeffsmale90
chore: Update @metamask/signature-controller (#20202)
97ba5d6 
## **Description**

Updates the dependency on @metamask/signature-controller to 34.0.0

This version bump introduces a dependency on
@metamask/gator-permissions-controller via
`GatorPermissionsControllerDecodePermissionFromPermissionContextForOriginAction`
which has been added to signature-controller-messenger.

## **Changelog**

From SignatureController
https://github.com/MetaMask/core/blob/main/packages/signature-controller/CHANGELOG.md:

### @metamask/signature-controller 34.0.0

#### Added

- Add two new controller state metadata properties: includeInStateLogs
and usedInUi (MetaMask/core#6473)
- Decode delegation permissions using
`@metamask/gator-permissions-controller` when calling
`newUnsignedTypedMessage`
([#6619](MetaMask/core#6619))

#### Changed

- Bump @metamask/controller-utils from ^11.12.0 to ^11.14.0
(MetaMask/core#6620,
MetaMask/core#6629)
- Bump @metamask/base-controller from ^8.1.0 to ^8.4.0
(MetaMask/core#6355,
MetaMask/core#6465,
MetaMask/core#6632)
- Bump @metamask/utils from ^11.4.2 to ^11.8.0
(MetaMask/core#6588)

### @metamask/signature-controller 33.0.0

#### Changed

- BREAKING: Bump peer dependency @metamask/accounts-controller from
^32.0.0 to ^33.0.0 (MetaMask/core#6345)
- BREAKING: Bump peer dependency @metamask/keyring-controller from
^22.0.0 to ^23.0.0 (MetaMask/core#6345)
- Bump @metamask/base-controller from ^8.0.1 to ^8.1.0
(MetaMask/core#6284)
- Bump @metamask/controller-utils from ^11.11.0 to ^11.12.0
(MetaMask/core#6303)

CHANGELOG entry: null

## **Screenshots/Recordings**

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Upgrade @metamask/signature-controller to ^34 and allow
GatorPermissionsController decode action in the signature controller
messenger.
> 
> - **Dependencies**:
>   - Bump `@metamask/signature-controller` to `^34.0.0`.
> - **Engine**:
> -
**`app/core/Engine/messengers/signature-controller-messenger/signature-controller-messenger.ts`**:
> - Add
`GatorPermissionsControllerDecodePermissionFromPermissionContextForOriginAction`
and allow
`GatorPermissionsController:decodePermissionFromPermissionContextForOrigin`
in `allowedActions`.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
657705e. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcmire mcmire mcmire approved these changes

@mathieuartu mathieuartu mathieuartu approved these changes

Assignees

No one assigned

Labels

no-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Gudahtt @cryptodev-2s @mcmire @mathieuartu