Skip to content

Conversation

@mikesposito
Copy link
Member

@mikesposito mikesposito commented Sep 4, 2025

Explanation

This PR migrates ErrorReportingService to the new @metamask/messenger message bus, as opposed to the one exported from @metamask/base-controller.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Migrates ErrorReportingService to @metamask/messenger, updating types/tests/docs and introducing breaking changes (incl. metadata property rename).

  • @metamask/error-reporting-service:
    • Migration: Replace RestrictedMessenger from @metamask/base-controller with Messenger from @metamask/messenger in src/error-reporting-service.ts and tests.
    • API: Update ErrorReportingServiceMessenger type and usage to new namespaced messenger pattern (constructor wiring, messenger.call, delegation example).
    • Breaking Changes: Document switch to new Messenger and rename metadata anonymousincludeInDebugSnapshot in CHANGELOG.md.
    • Deps: Add @metamask/messenger to package.json.
  • Docs/Graph:
    • Update README dependency graph to include error_reporting_service --> messenger (and other minor graph edge).

Written by Cursor Bugbot for commit 06c5ef3. This will update automatically on new commits. Configure here.

@mikesposito mikesposito force-pushed the mikesposito/messenger/error-reporting-service branch from cc65bbf to 74e5fca Compare September 4, 2025 11:34
@mikesposito mikesposito mentioned this pull request Sep 4, 2025
43 tasks
@mikesposito mikesposito marked this pull request as ready for review September 4, 2025 11:35
@mikesposito mikesposito requested a review from a team as a code owner September 4, 2025 11:35
Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikesposito mikesposito enabled auto-merge October 27, 2025 10:38
@mikesposito mikesposito added this pull request to the merge queue Oct 27, 2025
@FrederikBolding FrederikBolding removed this pull request from the merge queue due to the queue being cleared Oct 27, 2025
@FrederikBolding FrederikBolding added this pull request to the merge queue Oct 27, 2025
Merged via the queue into main with commit 67888a6 Oct 27, 2025
256 of 257 checks passed
@FrederikBolding FrederikBolding deleted the mikesposito/messenger/error-reporting-service branch October 27, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants