-
-
Notifications
You must be signed in to change notification settings - Fork 260
feat: Add bulk token scanning and introduce shared cache manager #6617 #6483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se resultType instead of isMalicious and metadata
…g in PhishingController
…handling in PhishingController
…se more descriptive field names
…o extend TTL and increase max size
…rmat and simplify lookup logic
…ns method signature in PhishingController
…hishingController
…_ENDPOINT and update related comments for clarity
…in PhishingController
cryptotavares
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR extends the PhishingController to support bulk token screening with caching, similar to the existing URL scanning functionality. This PR also replaces the
urlScanCachewith a reusablecacheManagerclass that is shared between bothurlScanCacheand nowtokenScanCacheChanges introduced
bulkScanTokensmethod that can screen up to 100 tokens per batchcacheManagerclass that handles caching logic with a 15-minute TTL.urlScanCachewithcacheManager.tokenScanCacheusing the samecacheManagerfor consistency and reuse.${chainId}:${tokenAddress}for token scans.bulkScanTokensas a controller action underPhishingControllerBulkScanTokensAction.Screenshot showcasing the
tokenScanCacheis implemented as expectedThis is grabbed via the extension console using await stateHooks.getPersistedState() after triggering a swap in uniswap. You will notice i was doing a swap for USDC which is the only token address stored in the cache.
References
Checklist