refactor: migrate {Authentication,UserStorage}Controller to @metamask/messenger

[cryptodev-2s]

Explanation

This PR migrates AuthenticationController, UserStorageController to the new @metamask/messenger message bus, as opposed to the one exported from @metamask/base-controller.

References

• Related to Implement messenger delegation #5626

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
• I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

---

Note

Migrates AuthenticationController and UserStorageController to @metamask/messenger, renames state metadata anonymous -> includeInDebugSnapshot, and updates tests, configs, and deps.

• Profile Sync Controller:
  • Migrate AuthenticationController and UserStorageController from @metamask/base-controller messenger to @metamask/messenger (messagingSystem -> messenger; new handler/subscribe/call usage; updated types).
  • Update imports to @metamask/base-controller/next.
  • Rename state metadata key anonymous to includeInDebugSnapshot and adjust tests accordingly.
  • Revise tests/mocks to construct root/child messengers and delegate permissions; adapt mock handlers (e.g., SnapController:handleRequest).
• Dependencies/Config:
  • Add @metamask/messenger dependency and TS project references; update yarn.lock.
  • Update README dependency graph to include @metamask/messenger and new edges.

^{Written by Cursor Bugbot for commit b09e552. This will update automatically on new commits. Configure here.}

[mcmire]

LGTM!