refactor: migrate {Permission,SubjectMetadata}Controller to @metamask/messenger

[cryptodev-2s]

Explanation

This PR migrates PermissionController and SubjectMetadataController to the new @metamask/messenger message bus, as opposed to the one exported from @metamask/base-controller.

References

• Related to Implement messenger delegation #5626

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
• I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

---

Note

Migrates PermissionController and SubjectMetadataController to the new @metamask/messenger API and renames the state metadata flag from anonymous to includeInDebugSnapshot.

• BREAKING:
  • Replace RestrictedMessenger (from @metamask/base-controller) with new Messenger (from @metamask/messenger) across packages/permission-controller.
  • Rename state metadata property anonymous to includeInDebugSnapshot.
• PermissionController (src/PermissionController.ts, src/Permission.ts):
  • Update types (PermissionControllerMessenger, SideEffectMessenger, SideEffectParams.messenger).
  • Replace messagingSystem with messenger; switch to registerActionHandler/messenger.call throughout.
  • Adjust validators and side-effects to use new messenger; minor JSDoc/typo fixes.
• SubjectMetadataController (src/SubjectMetadataController.ts):
  • Migrate to new Messenger; update action registration; update state metadata flag.
• Tests (PermissionController.test.ts, SubjectMetadataController.test.ts):
  • Refactor to construct root messenger and delegate actions; update imports to @metamask/base-controller/next and new messenger types.
• Package/Config:
  • Add dependency @metamask/messenger@^0.3.0; add TS project references; update README dependency graph to include messenger and new edges; adjust ESLint thresholds; update lockfile.

^{Written by Cursor Bugbot for commit cf46a11. This will update automatically on new commits. Configure here.}

[mcmire]

LGTM!