-
-
Notifications
You must be signed in to change notification settings - Fork 262
refactor: migrate {NotificationServices,NotificationServicesPush}Controller to @metamask/messenger
#6538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
FrederikBolding
merged 5 commits into
main
from
cryptodev-2s/messenger/notification-services-controller
Oct 27, 2025
Merged
refactor: migrate {NotificationServices,NotificationServicesPush}Controller to @metamask/messenger
#6538
FrederikBolding
merged 5 commits into
main
from
cryptodev-2s/messenger/notification-services-controller
Oct 27, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
851b86f to
e948005
Compare
43 tasks
mcmire
reviewed
Sep 10, 2025
...ervices-controller/src/NotificationServicesController/NotificationServicesController.test.ts
Show resolved
Hide resolved
...ion-services-controller/src/NotificationServicesPushController/__fixtures__/mockMessenger.ts
Outdated
Show resolved
Hide resolved
...ion-services-controller/src/NotificationServicesController/NotificationServicesController.ts
Show resolved
Hide resolved
...ion-services-controller/src/NotificationServicesController/NotificationServicesController.ts
Show resolved
Hide resolved
...ices-controller/src/NotificationServicesPushController/NotificationServicesPushController.ts
Show resolved
Hide resolved
...ices-controller/src/NotificationServicesPushController/NotificationServicesPushController.ts
Show resolved
Hide resolved
5bf8c54 to
873453d
Compare
{NotificationServices,NotificationServicesPush}Controller to `@metamask/messenger{NotificationServices,NotificationServicesPush}Controller to @metamask/messenger
…roller to @metamask/messenger
873453d to
1df4622
Compare
mcmire
previously approved these changes
Oct 7, 2025
Contributor
mcmire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…r/notification-services-controller
Mrtenz
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR migrates
NotificationServicesControllerandNotificationServicesPushControllerto the new@metamask/messengermessage bus, as opposed to the one exported from@metamask/base-controller.References
Checklist
Note
Migrates Notification Services controllers to the new @metamask/messenger, updates metadata flag, and adjusts tests/configs accordingly.
NotificationServicesControllerandNotificationServicesPushControllerfromRestrictedMessenger(@metamask/base-controller) toMessenger(@metamask/messenger), updating allcall/subscribe/publish/registerActionHandlerusages.@metamask/base-controller/nextforBaseControllerandderiveStateFromMetadata.anonymoustoincludeInDebugSnapshotin code and tests.AllowedActions/AllowedEvents; keep as internal types.@metamask/messenger@^0.3.0; add TS project references topackages/messenger.notification_services_controller --> messengerand addeip_7702_internal_rpc_middleware --> controller_utils.Written by Cursor Bugbot for commit 6b8f905. This will update automatically on new commits. Configure here.