-
-
Notifications
You must be signed in to change notification settings - Fork 262
refactor: migrate NetworkEnablementController to @metamask/messenger
#6540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
FrederikBolding
merged 7 commits into
main
from
cryptodev-2s/messenger/network-enablement-controller
Oct 27, 2025
Merged
refactor: migrate NetworkEnablementController to @metamask/messenger
#6540
FrederikBolding
merged 7 commits into
main
from
cryptodev-2s/messenger/network-enablement-controller
Oct 27, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 tasks
294d507 to
9130d1e
Compare
9130d1e to
44f2265
Compare
mcmire
reviewed
Sep 10, 2025
packages/network-enablement-controller/src/NetworkEnablementController.test.ts
Outdated
Show resolved
Hide resolved
44f2265 to
c7b3883
Compare
mcmire
requested changes
Oct 7, 2025
packages/network-enablement-controller/src/NetworkEnablementController.test.ts
Outdated
Show resolved
Hide resolved
mcmire
previously approved these changes
Oct 7, 2025
Contributor
mcmire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…r/network-enablement-controller
Mrtenz
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR migrates
NetworkEnablementControllerto the new@metamask/messengermessage bus, as opposed to the one exported from@metamask/base-controller.References
Checklist
Note
Migrates
NetworkEnablementControllerto the new@metamask/messengerAPI, updates metadata and tests, and adds related package/config references.RestrictedMessenger(@metamask/base-controller) toMessenger(@metamask/messenger); update typeNetworkEnablementControllerMessengerand wiring.@metamask/base-controller/nextand replacemessagingSystem.callwithmessenger.call.anonymoustoincludeInDebugSnapshot.src/NetworkEnablementController.test.ts):Messengerinstances with delegation; publish viarootMessenger.messenger.call; remove old helper and adjust setups accordingly.@metamask/messengerdependency and TS project references; update README dependency graph to includemessengerand link fromnetwork_enablement_controller.Written by Cursor Bugbot for commit e8eff3b. This will update automatically on new commits. Configure here.