refactor: migrate MultichainTransactionsController to @metamask/messenger
#6542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 tasks
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
mcmire
previously approved these changes
Sep 10, 2025
cryptodev-2s
force-pushed
the
cryptodev-2s/messenger/multichain-transactions-controller
branch
from
57b9797 to
f10d859
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
mcmire
previously approved these changes
Oct 7, 2025
packages/multichain-transactions-controller/src/MultichainTransactionsController.test.ts
Show resolved
Hide resolved
…r/multichain-transactions-controller
…r/multichain-transactions-controller * origin/main: (35 commits) feat: `JsonRpcEngineV2` (#6176) Release 641.0.0 (#6940) feat: Add transaction emulation actions (#6935) Release/640.0.0 (#6934) fix(core-backend): control randomness to fix flaky test (#6936) chore: Add `@metamask-previews/*` to NPM age gate exceptions (#6937) Release/639.0.0 (#6931) feat: make getCryptoApproveTransactionParams synchronous (#6930) feat: add new actions to `KeyringController` (#6928) feat: add `getAccounts` to `AccountsController` (#6927) chore: remove `Monad Mainnet` single call balance contract and add into account v4 (#6929) Release/638.0.0 (#6923) fix: Downgrade `multiformats` to `^9.9.0` to avoid ESM-only dependency (#6920) Release/637.0.0 (#6919) feat(account-tree-controller): add callbacks for hidden and pinned data (#6910) Release 636.0.0 (#6918) fix(core-backend): reconnection logic (#6861) fix: Tx state listener and signature coverage (#6906) Release/635.0.0 (#6917) fix(base-controller): add TypeScript declaration file for legacy module resolution (#6915) ...
| }; | ||
|
|
||
| const publishSpy = jest.spyOn(messenger, 'publish'); | ||
| const publishSpy = jest.spyOn(rootMessenger, 'publish'); |
There was a problem hiding this comment.
Bug: Test Misconfiguration Affects Event Verification
The "does not publish events for other transaction statuses" test spies on the rootMessenger instead of the controller's own messenger. This prevents it from accurately verifying the MultichainTransactionsController's event publishing behavior, making its assertions ineffective and inconsistent with other event-related tests.
FrederikBolding
approved these changes
Oct 27, 2025
auto-merge was automatically disabled
October 27, 2025 11:38
Pull Request is not mergeable
FrederikBolding
removed this pull request from the merge queue due to the queue being cleared
FrederikBolding
deleted the
cryptodev-2s/messenger/multichain-transactions-controller
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR migrates
MultichainTransactionsControllerto the new@metamask/messengermessage bus, as opposed to the one exported from@metamask/base-controller.References
Checklist
Note
Migrates
MultichainTransactionsControllerto@metamask/messengerand updates metadata, tests, and configs accordingly.RestrictedMessenger(@metamask/base-controller) toMessenger(@metamask/messenger), replacingmessagingSystem.*withmessenger.*and importing from@metamask/base-controller/next.anonymoustoincludeInDebugSnapshot.Messengerwith delegation, publishing viarootMessenger, and updatesderiveStateFromMetadatausage.@metamask/messengerand updates TS project references.multichain_transactions_controller --> messenger.Messengerand metadata rename.Written by Cursor Bugbot for commit 87bee34. This will update automatically on new commits. Configure here.