27.1.0 #755
Merged
27.1.0 #755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmire
reviewed
Mar 25, 2022
added 2 commits
March 25, 2022 13:26
Gudahtt
reviewed
Mar 25, 2022
Gudahtt
reviewed
Mar 25, 2022
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
mcmire
approved these changes
Mar 28, 2022
Member
|
TypeScript consumer of this version (like swaps-controller) will fail on type checking because https://github.com/MetaMask/controllers/blob/main/src/keyring/KeyringController.ts#L17-L20 But that dependency is declared in
~/p/c/controllers ❯❯❯ yarn why @keystonehq/metamask-airgapped-keyring main
yarn why v1.22.17
[1/4] 🤔 Why do we have the module "@keystonehq/metamask-airgapped-keyring"...?
[2/4] 🚚 Initialising dependency graph...
[3/4] 🔍 Finding dependency...
[4/4] 🚡 Calculating file sizes...
=> Found "@keystonehq/metamask-airgapped-keyring@0.3.0"
info Has been hoisted to "@keystonehq/metamask-airgapped-keyring"
info This module exists because it's specified in "devDependencies". |
Contributor
|
Ugh I missed that on the PR 😩 Okay we should probably issue a hotfix moving this to |
Member
|
@mcmire will |
Contributor
|
PR to address this here: #757 |
Contributor
|
@wachunei No but I think if you add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the release candidate for version 27.1.0.