Skip to content

Add clear function for NotificationController #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
FrederikBolding merged 2 commits into from
Oct 25, 2022
Merged

Add clear function for NotificationController #943

FrederikBolding merged 2 commits into from
Oct 25, 2022

Conversation

@FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Oct 21, 2022

Adds clear function to the NotificationController so we can delete the entire controller state at will. This will be useful for when restoring the vault.

Itemize the changes you have made into the categories below

  • ADDED:
    • Added clear function to the NotificationController

Checklist

  • Tests are included if applicable
  • Any added code is fully documented

@FrederikBolding FrederikBolding requested a review from a team as a code owner October 21, 2022 15:29
Gudahtt
Gudahtt approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@FrederikBolding FrederikBolding merged commit af8ebf0 into main Oct 25, 2022
@FrederikBolding FrederikBolding deleted the fb/add-clear-for-notifications-controller branch October 25, 2022 14:52
Gudahtt added a commit that referenced this pull request Oct 31, 2022
@Gudahtt
Merge remote-tracking branch 'origin/main' into monorepo-poc
5286350 
* origin/main:
  Use cached dependencies and immutable install during publish (#942)
  Add clear function for NotificationController (#943)
  Bump actions (#944)
gantunesr pushed a commit that referenced this pull request Dec 8, 2022
@FrederikBolding @gantunesr
Add clear function for NotificationController (#943)
0ceba76
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@FrederikBolding @MajorLift
Add clear function for NotificationController (#943)
0e4aba7
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@FrederikBolding @MajorLift
Add clear function for NotificationController (#943)
3e21270
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@FrederikBolding @Gudahtt