Skip to content

Adding a warning about token transfer for payments #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hanzel98 merged 3 commits into from
Apr 28, 2025
Merged

Adding a warning about token transfer for payments #101

hanzel98 merged 3 commits into from
Apr 28, 2025

Conversation

@hanzel98
Copy link
Contributor

@hanzel98 hanzel98 commented Apr 24, 2025

What?

  • Added a warning in the docs to make sure people secure their token transfer with an enforcer that checks the balance before and after.

Why?

  • Some tokens could return a boolean instead of reverting this is why it is important to validate the token balance.

@hanzel98 hanzel98 requested a review from a team as a code owner April 24, 2025 22:44
@hanzel98 hanzel98 self-assigned this Apr 24, 2025
@hanzel98 hanzel98 requested a review from McOso April 24, 2025 22:45
@hanzel98 hanzel98 merged commit bfca5f9 into main Apr 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@McOso McOso McOso approved these changes

Assignees

@hanzel98 hanzel98

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hanzel98 @McOso