Skip to content

Conversation

@hanzel98
Copy link
Contributor

What?

  • Adds an untracked lib

Why?

  • Without this lib it produces different deployment addresses

@hanzel98 hanzel98 requested a review from a team as a code owner June 18, 2025 15:02
@hanzel98 hanzel98 force-pushed the chore/adding-fcl-lib branch from 9f4064f to 2fcd9b9 Compare June 18, 2025 15:43
@hanzel98 hanzel98 marked this pull request as draft June 18, 2025 15:58
chore: remapping in toml and recursive

Fix GitHub Actions submodule issues - Add submodules: recursive to checkout action - Add remappings to foundry.toml for better CI reliability - Remove orphaned FreshCryptoLib submodule (duplicate of FCL)

Add FreshCryptoLib as proper submodule - Added submodule entry in .gitmodules - Updated remappings in both foundry.toml and remappings.txt - Pinned to specific commit d9bb3b0fc6b737af2c70dab246cabbc7d05afc3c

chore: reverting changes in the foundry toml
@hanzel98 hanzel98 force-pushed the chore/adding-fcl-lib branch from 0f61c27 to c3cb19c Compare June 18, 2025 17:21
@hanzel98 hanzel98 marked this pull request as ready for review June 18, 2025 17:21
Copy link
Contributor

@MoMannn MoMannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with and without. Without this change it produces different address, this fixes it.

@hanzel98 hanzel98 requested a review from McOso June 25, 2025 17:14
@hanzel98
Copy link
Contributor Author

These changes are necessary to generate the correct addresses for version 1.3.0 of the delegation framework.

@hanzel98 hanzel98 merged commit b3397b6 into main Jun 25, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants