Skip to content

Added only default mode protection to all enforcers #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
McOso merged 1 commit into from
Mar 17, 2025
Merged

Added only default mode protection to all enforcers #71

McOso merged 1 commit into from
Mar 17, 2025

Conversation

@hanzel98
Copy link
Contributor

@hanzel98 hanzel98 commented Mar 12, 2025 •
edited
Loading

What?

  • Protection was added so all enforcers must be in default mode.

Why?

  • Enforcers could store state on failed transactions that don't revert when using the try mode.

How?

  • Using the modifier onlyDefaultExecutionMode
  • Some functions failed with stack too deep error, this due to the maximum variables in memory, so I separated their logic to a new function to separate the context

@hanzel98 hanzel98 requested a review from a team as a code owner March 12, 2025 02:17
@hanzel98 hanzel98 self-assigned this Mar 12, 2025
@hanzel98 hanzel98 requested a review from McOso March 12, 2025 13:43
@McOso McOso merged commit acaa68b into main Mar 17, 2025
4 checks passed
@McOso McOso deleted the fix/enforcer-default-mode branch March 17, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@McOso McOso McOso approved these changes

Assignees

@hanzel98 hanzel98

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hanzel98 @McOso