feat: implement NativeTokenMaxLossEnforcer #85
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
NativeTokenMaxLossEnforcercaveat enforcer, which enforces that your native token balance losses do not exceed a max valueWhy?
How?
NativeBalanceGteEnforcer, and the logic and tests were just adapted since we're now capping the losses, rather than guaranteeing a minimum gain.Notes
As a side note, I had proposed to the team that we also rename our current
*BalanceGteEnforcercaveat enforcers to*MinGainEnforcer, since that naming more accurately describes what it enforces IMO.