Skip to content

Added Swaps ApiData Signature Validation #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hanzel98 merged 1 commit into from
Apr 7, 2025
Merged

Added Swaps ApiData Signature Validation #86

hanzel98 merged 1 commit into from
Apr 7, 2025

Conversation

@hanzel98
Copy link
Contributor

@hanzel98 hanzel98 commented Apr 4, 2025

What?

  • A signature validation on the Api Swap data and expiration time is added.

Why?

  • The MetaSwapAdapter is meant to be used with accurate swap data from the swaps API, these changes enforce that the swap data comes from the swaps API and it is recent data.

How?

  • Adding signature validation and expiration time.

@hanzel98 hanzel98 requested a review from a team as a code owner April 4, 2025 17:05
@hanzel98 hanzel98 self-assigned this Apr 4, 2025
@hanzel98 hanzel98 requested a review from McOso April 4, 2025 17:05
@hanzel98 hanzel98 force-pushed the feat/api-data-signature branch from a2862a4 to 836be17 Compare April 7, 2025 17:43
@hanzel98 hanzel98 mentioned this pull request Apr 7, 2025
Merged
@hanzel98 hanzel98 merged commit b0ea519 into chore/adapter-whitelist Apr 7, 2025
4 checks passed
hanzel98 added a commit that referenced this pull request Apr 7, 2025
@hanzel98
Added Swaps ApiData Signature Validation (#86)
73b0e2e
hanzel98 added a commit that referenced this pull request Apr 11, 2025
@hanzel98
MetaSwap Adapter Optional Token Whitelist And Added Swaps ApiData Sig…
0f8e128 
…nature Validation (#72)

* Optional token whitelist validation

* Added whitelist flag to redeemByDelegation

* chore: added deployment script

* fix: issue in the deployment script

* chore: improved enforce whitelist to const values

* Added Swaps ApiData Signature Validation (#86)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@McOso McOso McOso approved these changes

Assignees

@hanzel98 hanzel98

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hanzel98 @McOso