Skip to content

Conversation

@hanzel98
Copy link
Contributor

What?

  • Decided to change the abi.encodePacked for the abi.encode since it is more recommended for dynamic types.
  • Added some tests for the function to validate the signature. Including one test with a hardcoded signature and data from the swaps API.

Why?

  • This is a security improvement, it is not recommended to use abi.encodePacked for dynamic types.

@hanzel98 hanzel98 requested a review from a team as a code owner April 24, 2025 00:46
@hanzel98 hanzel98 self-assigned this Apr 24, 2025
McOso
McOso previously approved these changes Apr 25, 2025
@hanzel98 hanzel98 merged commit 5befce7 into main Apr 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants