Skip to content
This repository was archived by the owner on Oct 16, 2025. It is now read-only.

Conversation

@legobeat
Copy link
Contributor

@legobeat legobeat commented Sep 21, 2023

Blocking

@legobeat legobeat added the dependencies Pull requests that update a dependency file label Sep 21, 2023
@legobeat legobeat marked this pull request as ready for review September 21, 2023 22:07
@legobeat legobeat requested a review from a team as a code owner September 21, 2023 22:07
@legobeat legobeat requested review from a team September 21, 2023 22:07
@socket-security
Copy link

socket-security bot commented Sep 25, 2023

Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@types/pify 3.0.2...5.0.2 None +0/-0 5.1 kB types

🚮 Removed packages: @types/clone@2.1.1, pify@3.0.0

mikesposito
mikesposito previously approved these changes Sep 25, 2023
Copy link
Member

@mikesposito mikesposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mikesposito
mikesposito previously approved these changes Sep 25, 2023
@legobeat
Copy link
Contributor Author

@mikesposito Thanks for review :) Original PR did not actually remove clone as a dependency. This has now been done here.

@mikesposito
Copy link
Member

@legobeat Good catch because I didn't notice 😄

@legobeat legobeat merged commit 0968bf0 into MetaMask:main Sep 25, 2023
@jimmywarting
Copy link

when dropping support for NodeJS v16 and below, then you can maybe native structuredClone?

@legobeat legobeat deleted the deps-replace-clone branch September 26, 2023 21:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants