Skip to content
This repository was archived by the owner on Oct 7, 2024. It is now read-only.

feat: handle accountNameSuggestion and displayConfirmation options in #handleAccountCreated #300

Merged
k-g-j merged 9 commits into from
May 28, 2024
Merged

feat: handle accountNameSuggestion and displayConfirmation options in #handleAccountCreated #300

k-g-j merged 9 commits into from
May 28, 2024

Conversation

@k-g-j
Copy link
Contributor

@k-g-j k-g-j commented May 23, 2024 •
edited
Loading

Description

  • Bumps the Keyring API to latest version (6.2.0) that has the optional fields of accountNameSuggestion and displayConfirmation in the AccountCreatedEventStruct
  • #handleAccountCreated now parses these new options from the message params and passes them along with other properties to the add account callback
  • Tests are added for the new scenarios of creating an account with a suggested name or display confirmation option

Dependent on PR 301

@k-g-j k-g-j requested a review from a team as a code owner May 23, 2024 21:00
@k-g-j k-g-j mentioned this pull request May 23, 2024
Merged
danroc
danroc reviewed May 24, 2024
View reviewed changes
danroc
danroc reviewed May 24, 2024
View reviewed changes
danroc
danroc reviewed May 24, 2024
View reviewed changes
ccharly
ccharly reviewed May 28, 2024
View reviewed changes
@k-g-j k-g-j added this pull request to the merge queue May 28, 2024
Merged via the queue into main with commit bc2af47 May 28, 2024
@k-g-j k-g-j deleted the feat/add-account-options branch May 28, 2024 19:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@danroc danroc danroc left review comments

@ccharly ccharly ccharly approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@k-g-j @ccharly @danroc