Skip to content
This repository was archived by the owner on Nov 9, 2023. It is now read-only.

Conversation

@FrederikBolding
Copy link
Member

Use the new version of @metamask/json-rpc-engine.

@FrederikBolding FrederikBolding requested a review from a team as a code owner April 25, 2023 10:05
@socket-security
Copy link

socket-security bot commented Apr 25, 2023

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
Mild CVE semver 7.5.0
Network access micro-ftch 0.3.1
No bug tracker micro-ftch 0.3.1
Unmaintained micro-ftch 0.3.1
  • Last Publish: 7/8/2021, 4:10:57 AM
No contributors or author data @ethereumjs/common 3.1.2
No contributors or author data @metamask/json-rpc-engine 7.0.0
No contributors or author data @metamask/utils 5.0.1
No contributors or author data superstruct 1.0.3
Unmaintained @types/ms 0.7.31
  • Last Publish: 9/4/2019, 8:48:44 PM
Unmaintained crc-32 1.2.2
  • Last Publish: 4/4/2022, 11:05:52 PM
Unmaintained @scure/base 1.1.1
  • Last Publish: 6/15/2022, 10:20:05 AM

Next steps

What is a mild CVE?

Contains a low severity Common Vulnerability and Exposure (CVE).

Remove or replace dependencies that include known low severity CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Why are bug trackers important?

Package does not have a linked bug tracker in package.json.

Add a bugs field to package.json. https://docs.npmjs.com/cli/v8/configuring-npm/package-json#bugs

What are unmaintained packages?

Package has not been updated in more than a year and may be unmaintained. Problems with the package may go unaddressed.

Package should publish periodic maintenance releases if they are maintained, or deprecate if they have no intention in further maintenance.

Why is contributor and author data important?

Package does not specify a list of contributors or an author in package.json.

Add a author field or contributors array to package.json.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore semver@7.5.0
  • @SocketSecurity ignore @ethereumjs/common@3.1.2
  • @SocketSecurity ignore @metamask/json-rpc-engine@7.0.0
  • @SocketSecurity ignore @metamask/utils@5.0.1
  • @SocketSecurity ignore superstruct@1.0.3
  • @SocketSecurity ignore micro-ftch@0.3.1
  • @SocketSecurity ignore @types/ms@0.7.31
  • @SocketSecurity ignore crc-32@1.2.2
  • @SocketSecurity ignore @scure/base@1.1.1

@socket-security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/json-rpc-engine 7.0.0 network +19 4.06 MB metamaskbot

🚮 Removed packages: json-rpc-engine@6.1.0

@legobeat legobeat mentioned this pull request Sep 4, 2023
3 tasks
@FrederikBolding
Copy link
Member Author

Closing in favor of #54

@FrederikBolding FrederikBolding deleted the fb/bump-json-rpc-engine branch September 4, 2023 22:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants