6.1.0 #105
Merged
6.1.0 #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrtenz
reviewed
Jan 9, 2023
Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
Mrtenz
previously approved these changes
Jan 9, 2023
mcmire
reviewed
Jan 9, 2023
|
|
||
| ## [6.1.0] | ||
| ### Changed | ||
| - Update BIP-39 implementation from `@scure/bip39` to MetaMask fork version `@metamask/scure-bip39` ([#101](https://github.com/MetaMask/key-tree/pull/101)) |
There was a problem hiding this comment.
I know that it's given in the PR, but maybe it's worth explaining what the fork does over the original implementation?
Mrtenz
reviewed
Jan 10, 2023
Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
Mrtenz
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the release candidate for version 6.1.0.
[6.1.0]
Changed
bip39implementation fromscure-bip39to metamask fork version@metamask/scure-bip39(#101)@metamask/scure-bip39fork accepts secret recovery phrases inUint8Arrayformat making it possible to use more secure patterns of passing secret recovery phrases around. This change is non-breaking however, as themnemonicToSeedfunction used in this package still accepts secret recovery phrases in string format.