This repository was archived by the owner on Oct 7, 2024. It is now read-only.
Remove @metamask/snaps-ui from dependency tree #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: @metamask/snaps-rpc-methods@3.3.0, @metamask/snaps-utils@3.3.0 |
This comment was marked as outdated.
This comment was marked as outdated.
- The versions of `@metamask/snaps-controllers` and `@metamask/snaps-rpc-methods` that this package uses rely on `@metamask/snaps-ui`, which has recently been deprecated. The deprecation causes the dependencies audit on the extension to fail. - Global objects have been moved out of `@metamask/snaps-rpc-methods` to `@metamask/snaps-sdk`. Specifically, `SnapsGlobalObject` was renamed to `SnapsProvider`. Given these changes, this commit bumps `@metamask/snaps-controllers` and replaces `@metamask/snaps-rpc-methods` with `@metamask/snaps-sdk`, using `SnapsGlobalObject` instead of `SnapsProvider`.
mcmire
force-pushed
the
replace-snaps-rpc-methods
branch
from
fc48169 to
3f98d7b
Compare
mcmire
changed the title
owencraston
approved these changes
Nov 20, 2023
danroc
approved these changes
Nov 21, 2023
legobeat
added a commit
that referenced
this pull request
Dec 6, 2023
legobeat
added a commit
that referenced
this pull request
Dec 6, 2023
danroc
pushed a commit
that referenced
this pull request
Dec 7, 2023
danroc
pushed a commit
that referenced
this pull request
Dec 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@metamask/snaps-controllersand@metamask/snaps-rpc-methodsthat this package uses rely on@metamask/snaps-ui, which has recently been deprecated. The deprecation causes the dependencies audit on the extension to fail.@metamask/snaps-rpc-methodsto@metamask/snaps-sdk. Specifically,SnapsGlobalObjectwas renamed toSnapsProvider.Given these changes, this commit bumps
@metamask/snaps-controllersand replaces@metamask/snaps-rpc-methodswith@metamask/snaps-sdk, usingSnapsGlobalObjectinstead ofSnapsProvider.