This repository was archived by the owner on Oct 7, 2024. It is now read-only.
refactor: remove dependency to @metamask/providers + use local BaseProvider type #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/@metamask/providers@16.0.0 |
ccharly
force-pushed
the
refactor/use-local-provider-type
branch
from
260b8e7 to
f45b1dc
Compare
Contributor
Author
|
See this instead: #282 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was having a hard time with some incompatible versions of the
@metamask/providersthat we might have when mixing both thekeyring-apiupdates andsnaps-sdk.To avoid such problems in the future, we can break this dependency by re-declaring a local "sufficient" type for our use for "providers".