This repository was archived by the owner on Oct 7, 2024. It is now read-only.
refactor: split account types #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccharly
force-pushed
the
refactor/split-account-type
branch
from
f85ce44 to
faa242d
Compare
This allow to have proper error messages rather than confusing superstruct messages when dealing with union(s)!
ccharly
force-pushed
the
refactor/split-account-type
branch
from
faa242d to
bb84603
Compare
gantunesr
reviewed
Apr 23, 2024
Member
gantunesr
left a comment
gantunesr
left a comment
There was a problem hiding this comment.
Left some comments about the acronyms capitalization, this is a minor comment that can lead to a breaking change so feel free to ignore them if it's not worth it
Member
|
is there a ticket we can link this PR to? |
Co-authored-by: Gustavo Antunes <17601467+gantunesr@users.noreply.github.com>
1 task
Contributor
Author
|
The only issue I can think of right now would be this one: https://github.com/MetaMask/accounts-planning/issues/385 |
gantunesr
previously approved these changes
Apr 24, 2024
danroc
reviewed
Apr 24, 2024
danroc
reviewed
Apr 24, 2024
danroc
reviewed
Apr 24, 2024
danroc
reviewed
Apr 24, 2024
danroc
reviewed
Apr 24, 2024
danroc
reviewed
Apr 24, 2024
Co-authored-by: Daniel Rocha <daniel.rocha@consensys.net>
Co-authored-by: Daniel Rocha <daniel.rocha@consensys.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits the existing
KeyringAccounttype into two sub-types. Allowing to have "concrete" types for EOA and 4337 accounts.This is not a breaking change since
KeyringAccountnow uses aunionto match any of the 2 account types.Relates https://github.com/MetaMask/accounts-planning/issues/385